Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 728673002: remove unused kLCD_MaskFormat (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove unused kLCD_MaskFormat BUG=skia: Committed: https://skia.googlesource.com/skia/+/d54d3fc82456f8789b3e4dff40faeb7b670bcf4b

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove associated Gr enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -406 lines) Patch
M include/core/SkMask.h View 3 chunks +3 lines, -17 lines 0 comments Download
M include/gpu/GrTypes.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M src/core/SkAAClip.cpp View 3 chunks +1 line, -14 lines 0 comments Download
M src/core/SkBlitMask_D32.cpp View 6 chunks +0 lines, -198 lines 0 comments Download
M src/core/SkGlyph.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/core/SkMask.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkScalerContext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkScalerContext.cpp View 4 chunks +0 lines, -34 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrFontScaler.cpp View 1 2 3 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 3 chunks +1 line, -34 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 5 chunks +7 lines, -48 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 3 chunks +3 lines, -28 lines 0 comments Download
M tests/AAClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
reed1
6 years, 1 month ago (2014-11-13 21:30:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728673002/1
6 years, 1 month ago (2014-11-13 21:31:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 21:31:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728673002/20001
6 years, 1 month ago (2014-11-13 21:37:52 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 21:37:53 UTC) #8
reed1
caught two more with grep - LCD32
6 years, 1 month ago (2014-11-13 21:38:06 UTC) #9
reed1
6 years, 1 month ago (2014-11-13 22:01:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728673002/40001
6 years, 1 month ago (2014-11-13 22:01:59 UTC) #13
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 22:02:03 UTC) #14
bsalomon
lgtm
6 years, 1 month ago (2014-11-13 22:03:07 UTC) #15
bungeman-skia
lgtm
6 years, 1 month ago (2014-11-13 22:03:22 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/691)
6 years, 1 month ago (2014-11-13 22:19:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728673002/40001
6 years, 1 month ago (2014-11-13 22:22:52 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 22:40:02 UTC) #21
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d54d3fc82456f8789b3e4dff40faeb7b670bcf4b

Powered by Google App Engine
This is Rietveld 408576698