src/ports/SkFontHost_FreeType_common.cpp - Issue 728673002: remove unused kLCD_MaskFormat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_FreeType_common.cpp

Issue 728673002: remove unused kLCD_MaskFormat (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: remove associated Gr enum Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_FreeType_common.cpp

diff --git a/src/ports/SkFontHost_FreeType_common.cpp b/src/ports/SkFontHost_FreeType_common.cpp

index b53f9e3bf87f275097c7a2edfe67d1e33dab9ffa..bd3cddf596420ae61a898636945b344d7297fd02 100644

--- a/src/ports/SkFontHost_FreeType_common.cpp

+++ b/src/ports/SkFontHost_FreeType_common.cpp

@@ -165,14 +165,14 @@ static void copyFT2LCD16(const FT_Bitmap& bitmap, const SkMask& mask, int lcdIsB

* Yes, No, Never Requested, Never Produced

- * kBW kA8 k3D kARGB32 kLCD16 kLCD32

- * FT_PIXEL_MODE_MONO Y Y NR N Y NR

- * FT_PIXEL_MODE_GRAY N Y NR N Y NR

- * FT_PIXEL_MODE_GRAY2 NP NP NR NP NP NR

- * FT_PIXEL_MODE_GRAY4 NP NP NR NP NP NR

- * FT_PIXEL_MODE_LCD NP NP NR NP NP NR

- * FT_PIXEL_MODE_LCD_V NP NP NR NP NP NR

- * FT_PIXEL_MODE_BGRA N N NR Y N NR

+ * kBW kA8 k3D kARGB32 kLCD16

+ * FT_PIXEL_MODE_MONO Y Y NR N Y

+ * FT_PIXEL_MODE_GRAY N Y NR N Y

+ * FT_PIXEL_MODE_GRAY2 NP NP NR NP NP

+ * FT_PIXEL_MODE_GRAY4 NP NP NR NP NP

+ * FT_PIXEL_MODE_LCD NP NP NR NP NP

+ * FT_PIXEL_MODE_LCD_V NP NP NR NP NP

+ * FT_PIXEL_MODE_BGRA N N NR Y N

* TODO: All of these N need to be Y or otherwise ruled out.

« no previous file with comments | « src/ports/SkFontHost_FreeType.cpp ('k') | src/ports/SkFontHost_mac.cpp » ('j') | no next file with comments »