Issue 728433002: Revert of move to modify onCreateDevice virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 728433002: Revert of move to modify onCreateDevice virtual (Closed)

Created:
6 years, 1 month ago by reed2

Modified:
6 years, 1 month ago

Reviewers:
f(malita), fmalita_google_do_not_use, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of move to modify onCreateDevice virtual (patchset #2 id:20001 of https://codereview.chromium.org/723743002/) Reason for revert: mac_chromium_rel_ng unittest failures. speculating caused by this cl. http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/5262 Original issue's description: > start to replace onCreateDevice with onCreateCompatibleDevice > > the new virtual takes a struct which we can amend in the future w/o having to > update our subclasses in chrome. > > BUG=skia: > NOTRY=True > > Committed: https://skia.googlesource.com/skia/+/b122ee50fb56cf6669fe1668b82c8815896e9943 TBR=fmalita@google.com,fmalita@chromium.org,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5adbf1b57988eaad84d6615395c90a08b7ea225a

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -37 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDevice.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/gpu/SkGpuDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/utils/SkDeferredCanvas.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/utils/SkPictureUtils.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728433002/1

6 years, 1 month ago (2014-11-13 11:31:23 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 11:31:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5adbf1b57988eaad84d6615395c90a08b7ea225a