Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 723743002: move to modify onCreateDevice virtual (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

start to replace onCreateDevice with onCreateCompatibleDevice the new virtual takes a struct which we can amend in the future w/o having to update our subclasses in chrome. BUG=skia: NOTRY=True Committed: https://skia.googlesource.com/skia/+/b122ee50fb56cf6669fe1668b82c8815896e9943

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -25 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkDevice.h View 2 chunks +12 lines, -0 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
reed1
6 years, 1 month ago (2014-11-12 21:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723743002/1
6 years, 1 month ago (2014-11-12 21:43:10 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-12 21:43:11 UTC) #5
f(malita)
lgtm
6 years, 1 month ago (2014-11-12 21:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723743002/20001
6 years, 1 month ago (2014-11-12 21:57:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723743002/20001
6 years, 1 month ago (2014-11-12 22:30:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/b122ee50fb56cf6669fe1668b82c8815896e9943
6 years, 1 month ago (2014-11-12 22:31:15 UTC) #13
reed2
6 years, 1 month ago (2014-11-13 11:31:01 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/728433002/ by reed@chromium.org.

The reason for reverting is: mac_chromium_rel_ng unittest failures. speculating
caused by this cl.

http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_....

Powered by Google App Engine
This is Rietveld 408576698