Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 728043002: Revert of Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480 (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480 (patchset #3 id:40001 of https://codereview.chromium.org/728553002/) Reason for revert: Breaks incremental builds, crbug.com/433524 Original issue's description: > Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480 > > TBR=jam@chromium.org > > Committed: https://crrev.com/184f354ddeff66784515ddbbee9c46355cadab6a > Cr-Commit-Position: refs/heads/master@{#304114} TBR=jam@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/671db43a735bd2297225b9d74129402e66fdc549 Cr-Commit-Position: refs/heads/master@{#304305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3658 lines, -6509 lines) Patch
M build/all.gyp View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/battery/battery_monitor_impl.h View 1 chunk +8 lines, -10 lines 0 comments Download
M device/battery/battery_monitor_impl.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/BUILD.gn View 3 chunks +21 lines, -47 lines 0 comments Download
M mojo/edk/embedder/channel_init.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/channel_init.cc View 1 chunk +6 lines, -5 lines 0 comments Download
D mojo/edk/embedder/configuration.h View 1 chunk +0 lines, -68 lines 0 comments Download
M mojo/edk/embedder/embedder.h View 4 chunks +12 lines, -19 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 8 chunks +31 lines, -35 lines 0 comments Download
D mojo/edk/embedder/embedder_internal.h View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 15 chunks +166 lines, -67 lines 0 comments Download
D mojo/edk/embedder/entrypoints.cc View 1 chunk +0 lines, -155 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 5 chunks +14 lines, -10 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_win.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M mojo/edk/embedder/platform_channel_utils_posix.h View 3 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/embedder/platform_handle_utils.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/embedder/platform_handle_utils_win.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_posix.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/edk/embedder/simple_platform_shared_buffer_win.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M mojo/edk/embedder/test_embedder.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/js/BUILD.gn View 2 chunks +4 lines, -17 lines 0 comments Download
M mojo/edk/js/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/core.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/js/core.cc View 1 chunk +63 lines, -67 lines 0 comments Download
M mojo/edk/js/drain_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/js/handle.h View 3 chunks +9 lines, -3 lines 0 comments Download
M mojo/edk/js/handle.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/edk/js/handle_close_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/edk/js/mojo_runner_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/edk/js/mojo_runner_delegate.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M mojo/edk/js/support.h View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/edk/js/test/BUILD.gn View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/edk/js/test/hexdump.js View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/edk/js/test/run_js_integration_tests.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/edk/js/test/run_js_tests.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +6 lines, -15 lines 0 comments Download
A mojo/edk/js/tests/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
D mojo/edk/js/tests/connection_tests.js View 1 chunk +0 lines, -261 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp.mojom View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +0 lines, -418 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.js View 1 chunk +0 lines, -221 lines 0 comments Download
A mojo/edk/js/tests/run_js_tests.cc View 1 chunk +64 lines, -0 lines 0 comments Download
D mojo/edk/js/tests/sample_service_tests.js View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/edk/js/threading.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/edk/js/threading.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M mojo/edk/js/waiting_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/mojo_edk.gyp View 7 chunks +276 lines, -42 lines 0 comments Download
D mojo/edk/mojo_edk_tests.gyp View 1 chunk +0 lines, -278 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 7 chunks +31 lines, -44 lines 0 comments Download
M mojo/edk/system/channel.h View 4 chunks +0 lines, -11 lines 0 comments Download
M mojo/edk/system/channel.cc View 7 chunks +9 lines, -16 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/channel_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_info.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D mojo/edk/system/channel_manager.h View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/edk/system/channel_manager.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/edk/system/channel_unittest.cc View 3 chunks +9 lines, -6 lines 0 comments Download
D mojo/edk/system/configuration.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/edk/system/configuration.cc View 1 chunk +0 lines, -26 lines 0 comments Download
A mojo/edk/system/constants.h View 1 chunk +48 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 8 chunks +30 lines, -18 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 56 chunks +557 lines, -314 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +7 lines, -6 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 6 chunks +18 lines, -25 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_unittest.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/dispatcher.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 3 chunks +76 lines, -57 lines 0 comments Download
A mojo/edk/system/entrypoints.h View 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/edk/system/entrypoints.cc View 1 chunk +191 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 8 chunks +18 lines, -21 lines 0 comments Download
M mojo/edk/system/local_data_pipe.h View 1 chunk +6 lines, -5 lines 0 comments Download
M mojo/edk/system/local_data_pipe.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/local_data_pipe_unittest.cc View 98 chunks +413 lines, -256 lines 0 comments Download
M mojo/edk/system/mapping_table.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/edk/system/memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/memory.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 4 chunks +16 lines, -9 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 4 chunks +13 lines, -14 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 16 chunks +97 lines, -44 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 4 chunks +25 lines, -11 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 22 chunks +179 lines, -79 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 15 chunks +77 lines, -38 lines 0 comments Download
M mojo/edk/system/options_validation.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/raw_channel.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 7 chunks +22 lines, -16 lines 0 comments Download
M mojo/edk/system/raw_channel_posix.cc View 6 chunks +20 lines, -10 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M mojo/edk/system/raw_channel_win.cc View 5 chunks +23 lines, -15 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 40 chunks +277 lines, -164 lines 0 comments Download
M mojo/edk/system/run_all_unittests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 8 chunks +60 lines, -40 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 9 chunks +98 lines, -38 lines 0 comments Download
M mojo/edk/system/test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/transport_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/transport_data.cc View 7 chunks +23 lines, -21 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/test/run_all_unittests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/test_support_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/test_utils_win.cc View 4 chunks +26 lines, -13 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/lib/DEPS View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_main.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/bindings/binding.h View 1 chunk +0 lines, -136 lines 0 comments Download
M mojo/public/cpp/bindings/interface_impl.h View 6 chunks +30 lines, -60 lines 0 comments Download
A mojo/public/cpp/bindings/lib/interface_impl_internal.h View 1 chunk +128 lines, -0 lines 0 comments Download
D mojo/public/cpp/bindings/strong_binding.h View 1 chunk +0 lines, -88 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 11 chunks +19 lines, -149 lines 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download
M mojo/public/dart/BUILD.gn View 2 chunks +0 lines, -46 lines 0 comments Download
D mojo/public/dart/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/dart/README View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/public/dart/core.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/public/dart/mojo_init.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/public/dart/src/buffer.dart View 1 chunk +0 lines, -107 lines 0 comments Download
D mojo/public/dart/src/data_pipe.dart View 1 chunk +0 lines, -191 lines 0 comments Download
D mojo/public/dart/src/handle.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/public/dart/src/message_pipe.dart View 1 chunk +0 lines, -155 lines 0 comments Download
D mojo/public/dart/src/mojo_dart_core.cc View 1 chunk +0 lines, -659 lines 0 comments Download
D mojo/public/dart/src/types.dart View 1 chunk +0 lines, -116 lines 0 comments Download
M mojo/public/go/system/impl/mojo_types.go View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 5 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/ServiceMessage.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/DataPipe.java View 2 chunks +1 line, -14 lines 0 comments Download
M mojo/public/js/core.js View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/js/core_unittests.js View 3 chunks +15 lines, -10 lines 0 comments Download
D mojo/public/js/threading.js View 1 chunk +0 lines, -21 lines 0 comments Download
M mojo/public/mojo_public.gyp View 6 chunks +24 lines, -39 lines 0 comments Download
M mojo/public/python/mojo/bindings/descriptor.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/python/mojo/bindings/messaging.py View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/public/python/mojo/bindings/serialization.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/python/mojo/c_core.pxd View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/python/mojo/system.pyx View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +58 lines, -5 lines 0 comments Download
D mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/public/tools/bindings/mojom_bindings_generator_variables.gypi View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/public/tools/bindings/mojom_list_outputs.py View 1 chunk +0 lines, -34 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_factory.cc View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/public/interfaces/accessibility/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/public/interfaces/accessibility/accessibility.mojom View 1 chunk +0 lines, -35 lines 0 comments Download
M mojo/services/public/interfaces/network/cookie_store.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/js/mojo.js View 1 chunk +0 lines, -169 lines 0 comments Download
M ui/keyboard/webui/vk_mojo_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/keyboard/webui/vk_mojo_handler.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/keyboard/webui/vk_webui_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Created Revert of Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480
6 years, 1 month ago (2014-11-14 23:58:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/728043002/1
6 years, 1 month ago (2014-11-15 00:00:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-15 00:04:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/671db43a735bd2297225b9d74129402e66fdc549 Cr-Commit-Position: refs/heads/master@{#304305}
6 years, 1 month ago (2014-11-15 00:05:16 UTC) #4
dshwang
Thank you for it. Many've suffered for 2 days.
6 years, 1 month ago (2014-11-18 13:00:32 UTC) #5
dshwang
I guess ninja doesn't compare the updated time of .mojom files for some reasons.
6 years, 1 month ago (2014-11-18 13:03:32 UTC) #6
Nico
6 years, 1 month ago (2014-11-18 17:23:05 UTC) #7
Message was sent while issue was closed.
On 2014/11/18 13:03:32, dshwang wrote:
> I guess ninja doesn't compare the updated time of .mojom files for some
reasons.

Ninja does what it's told to do. It was told that to produce a .html file, it
should run a command. The command then didn't produce that html file though, so
the next time round ninja ran the command again.

Powered by Google App Engine
This is Rietveld 408576698