mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc - Issue 728043002: Revert of Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

Issue 728043002: Revert of Update mojo sdk to rev afb4440fd5a10cba980878c326180b7ad7960480 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h ('k') | mojo/services/public/cpp/view_manager/view_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

index cc04f04e61abfc293c573b8da05681f0e4a01c6a..860beb57c3b8982f2b90e0151fe028722e731789 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

@@ -199,9 +199,8 @@

Id view_id,

ServiceProviderPtr service_provider) {

DCHECK(connected_);

- service_->Embed(url, view_id,

- MakeRequest<ServiceProvider>(service_provider.PassMessagePipe()),

- ActionCompletedCallback());

+ service_->Embed(url, view_id, service_provider.Pass(),

+ ActionCompletedCallback());

}

void ViewManagerClientImpl::AddView(View* view) {