Issue 727983002: Add the generate_dump tool

Issue 727983002: Add the generate_dump tool (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@task_for_pid

Project:
crashpad

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+291 lines, -0 lines)			Patch
A	tools/generate_dump.ad	View	1 chunk	+95 lines, -0 lines	0 comments	Download
A	tools/generate_dump.cc	View	1 chunk	+178 lines, -0 lines	0 comments	Download
M	tools/tools.gyp	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

Mark Mentovai

This depends on https://codereview.chromium.org/728973002/ and https://codereview.chromium.org/727053002/.

6 years, 1 month ago (2014-11-14 21:52:24 UTC) #2

Robert Sesek

LGTM tools/ should probably move to tools/mac/ at some point.

6 years, 1 month ago (2014-11-14 23:57:38 UTC) #3

Mark Mentovai

I’m hoping that generate_dump will work on other platforms too, with minimal OS-specific code. But ...

6 years, 1 month ago (2014-11-15 00:21:34 UTC) #4

Mark Mentovai

Committed patchset #2 (id:20001) manually as 09d3a6c69573c16c632c46638d580e1491012ac6 (presubmit successful).

6 years, 1 month ago (2014-11-15 00:21:47 UTC) #5

Robert Sesek

6 years, 1 month ago (2014-11-15 00:27:46 UTC) #7

Message was sent while issue was closed.

On 2014/11/15 00:21:51, Mark Mentovai wrote:
> Thanks for today’s reviews!

Allays! It was an otherwise-luxurious week free of them :)