Source/devtools/front_end/ui/treeoutline.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/treeoutline.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/ui/ViewportDataGrid.js ('k') | Source/devtools/scripts/jsdoc-validator/hashes » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/treeoutline.js

diff --git a/Source/devtools/front_end/ui/treeoutline.js b/Source/devtools/front_end/ui/treeoutline.js

index 7bbea86ec05debc1966dac6beae1b5ebbcea1557..0a25fd25741e50c5e98a281a2c55fd93ce568717 100644

--- a/Source/devtools/front_end/ui/treeoutline.js

+++ b/Source/devtools/front_end/ui/treeoutline.js

@@ -679,7 +679,7 @@ TreeElement.treeElementToggled = function(event)

return;

if (element._selectionStarted) {

delete element._selectionStarted

- var selection = window.getSelection();

+ var selection = element.window().getSelection();

if (selection && !selection.isCollapsed && element.isSelfOrAncestor(selection.anchorNode) && element.isSelfOrAncestor(selection.focusNode))

return;

}