Source/devtools/front_end/ui/SplitView.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/SplitView.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/ui/SearchableView.js ('k') | Source/devtools/front_end/ui/TextPrompt.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/SplitView.js

diff --git a/Source/devtools/front_end/ui/SplitView.js b/Source/devtools/front_end/ui/SplitView.js

index b052e97cf3e5fdd9e6412e02489b4015a3dfbce0..e92b3e0f5600a4d666f5cbf59b5e1c631db0a31c 100644

--- a/Source/devtools/front_end/ui/SplitView.js

+++ b/Source/devtools/front_end/ui/SplitView.js

@@ -527,10 +527,10 @@ WebInspector.SplitView.prototype = {

this.dispatchEventToListeners(WebInspector.SplitView.Events.SidebarSizeChanged, this.sidebarSize());

return;

}

- this._animationFrameHandle = window.requestAnimationFrame(boundAnimationFrame);

+ this._animationFrameHandle = this.element.window().requestAnimationFrame(boundAnimationFrame);

}

boundAnimationFrame = animationFrame.bind(this);

- this._animationFrameHandle = window.requestAnimationFrame(boundAnimationFrame);

+ this._animationFrameHandle = this.element.window().requestAnimationFrame(boundAnimationFrame);

_cancelAnimation: function()

@@ -542,7 +542,7 @@ WebInspector.SplitView.prototype = {

this.element.style.removeProperty("transition");

if (this._animationFrameHandle) {

- window.cancelAnimationFrame(this._animationFrameHandle);

+ this.element.window().cancelAnimationFrame(this._animationFrameHandle);

delete this._animationFrameHandle;

}

if (this._animationCallback) {