Source/devtools/front_end/ui/FlameChart.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/FlameChart.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/ui/FilterBar.js ('k') | Source/devtools/front_end/ui/SearchableView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/FlameChart.js

diff --git a/Source/devtools/front_end/ui/FlameChart.js b/Source/devtools/front_end/ui/FlameChart.js

index 8c539eeb72945028ec98b1a806ce756b5530ba96..d8c5a01b2516ae45ac6283a25f7ea8371fbd5b73 100644

--- a/Source/devtools/front_end/ui/FlameChart.js

+++ b/Source/devtools/front_end/ui/FlameChart.js

@@ -486,7 +486,7 @@ WebInspector.FlameChart.prototype = {

}

this._cancelAnimation();

- this._cancelWindowTimesAnimation = WebInspector.animateFunction(this._animateWindowTimes.bind(this),

+ this._cancelWindowTimesAnimation = WebInspector.animateFunction(this.element.window(), this._animateWindowTimes.bind(this),

[{from: this._timeWindowLeft, to: startTime}, {from: this._timeWindowRight, to: endTime}], 5,

this._animationCompleted.bind(this));

this._pendingAnimationTimeLeft = startTime;

@@ -1287,7 +1287,7 @@ WebInspector.FlameChart.prototype = {

{

if (this._updateTimerId || this._cancelWindowTimesAnimation)

return;

- this._updateTimerId = requestAnimationFrame(this.update.bind(this));

+ this._updateTimerId = this.element.window().requestAnimationFrame(this.update.bind(this));

update: function()