Source/devtools/front_end/ui/DataGrid.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/DataGrid.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/toolbox/InspectedPagePlaceholder.js ('k') | Source/devtools/front_end/ui/FilterBar.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/ui/DataGrid.js

diff --git a/Source/devtools/front_end/ui/DataGrid.js b/Source/devtools/front_end/ui/DataGrid.js

index 8a99407e839fd81cb0c8165f0da24bbefb4fbd4a..0c8de8693aba8896ced0c834f37b8662f3cb72c4 100644

--- a/Source/devtools/front_end/ui/DataGrid.js

+++ b/Source/devtools/front_end/ui/DataGrid.js

@@ -283,7 +283,7 @@ WebInspector.DataGrid.prototype = {

var element = this._editingNode._element.children[cellIndex];

WebInspector.InplaceEditor.startEditing(element, this._startEditingConfig(element));

- window.getSelection().setBaseAndExtent(element, 0, element, 1);

+ element.window().getSelection().setBaseAndExtent(element, 0, element, 1);

_startEditing: function(target)

@@ -306,7 +306,7 @@ WebInspector.DataGrid.prototype = {

this._editing = true;

WebInspector.InplaceEditor.startEditing(element, this._startEditingConfig(element));

- window.getSelection().setBaseAndExtent(element, 0, element, 1);

+ element.window().getSelection().setBaseAndExtent(element, 0, element, 1);

renderInline: function()