Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/elements/ElementsTreeOutline.js ('k') | Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js

index 97ef5bcc75b89173a94d6a17bc04e551183fb719..26033d36b578dec635472a674d7f1db5e99aea47 100644

--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -341,7 +341,7 @@ WebInspector.MetricsSidebarPane.prototype = {

var config = new WebInspector.InplaceEditor.Config(this.editingCommitted.bind(this), this.editingCancelled.bind(this), context);

WebInspector.InplaceEditor.startEditing(targetElement, config);

- window.getSelection().setBaseAndExtent(targetElement, 0, targetElement, 1);

+ targetElement.window().getSelection().setBaseAndExtent(targetElement, 0, targetElement, 1);

_handleKeyDown: function(context, styleProperty, event)