Remove NPAPI support from Chrome Frame.

Remove 1) NPAPI support from Chrome Frame and 2) Firefox/Opera/Safari tests.

BUG=none
TEST=automated testing should suffice
R=ananta@chromium.org,robertshield@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90914

[grt (UTC plus 2), 2011-06-28 20:20:56]

Please point out any other dead code I've missed on this mission.  Thanks.

[robertshield, 2011-06-28 20:49:35]

Changes here lg, with a couple of nits and a touch of smugness :)

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/external_tab.h
File chrome_frame/external_tab.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/external_tab.h#...
chrome_frame/external_tab.h:80: //  background IPC-channel thread and the UI
object (ActiveX, ActiveDocument).
nit: *the background, also there is a parentheses mismatch.

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/navigation_cons...
File chrome_frame/navigation_constraints.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/navigation_cons...
chrome_frame/navigation_constraints.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
MWAHAHA! The day is mine! 2010 -> 2011

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/plugin_url_requ...
File chrome_frame/plugin_url_request.cc (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/plugin_url_requ...
chrome_frame/plugin_url_request.cc:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
2009 -> 2011. Also, mwahaha.

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/utils.h
File chrome_frame/utils.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/utils.h#newcode76
chrome_frame/utils.h:76: // Clears a marker that causes NPAPI registration to
persist across updates.
nit: causes *legacy* NPAPI registration

[grt (UTC plus 2), 2011-06-28 20:57:38]

Thank you, sir. I eagerly await your next CL for review.  :-)

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/external_tab.h
File chrome_frame/external_tab.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/external_tab.h#...
chrome_frame/external_tab.h:80: //  background IPC-channel thread and the UI
object (ActiveX, ActiveDocument).
On 2011/06/28 20:49:35, robertshield wrote:
> nit: *the background, also there is a parentheses mismatch.

Done.

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/navigation_cons...
File chrome_frame/navigation_constraints.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/navigation_cons...
chrome_frame/navigation_constraints.h:1: // Copyright (c) 2010 The Chromium
Authors. All rights reserved.
On 2011/06/28 20:49:35, robertshield wrote:
> MWAHAHA! The day is mine! 2010 -> 2011

Done.

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/plugin_url_requ...
File chrome_frame/plugin_url_request.cc (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/plugin_url_requ...
chrome_frame/plugin_url_request.cc:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
On 2011/06/28 20:49:35, robertshield wrote:
> 2009 -> 2011. Also, mwahaha.

Done.

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/utils.h
File chrome_frame/utils.h (right):

http://codereview.chromium.org/7276037/diff/6005/chrome_frame/utils.h#newcode76
chrome_frame/utils.h:76: // Clears a marker that causes NPAPI registration to
persist across updates.
On 2011/06/28 20:49:35, robertshield wrote:
> nit: causes *legacy* NPAPI registration

Done.

[ananta, 2011-06-28 21:12:24]

Please verify that CF histograms continue to work. The change LGTM.

[grt (UTC plus 2), 2011-06-29 00:48:04]

On 2011/06/28 21:12:24, ananta wrote:
> Please verify that CF histograms continue to work. The change LGTM.

Histograms look good.  In the debug log I see:

VERBOSE	1332	8080	20:33:00-469	.\metrics_service.cc	455	METRICS LOG: <log
clientid="..." buildtime="1309281392" appversion="14.0.805.0-F-devel"/>

Fiddler shows me the POST going out with these headers:

POST https://clients4.google.com/firefox/metrics/collect HTTP/1.1
Accept: */*
Content-Length: 137
Content-Type: application/vnd.mozilla.metrics.bz2
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64;
Trident/4.0; chromeframe/14.0.805.0; SLCC2; .NET CLR 2.0.50727; .NET CLR
3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C)
Accept-Encoding: gzip, deflate
Host: clients4.google.com
Connection: Keep-Alive
Cache-Control: no-cache
Cookie: PREF=ID=....

And the server responded with 200.

[commit-bot: I haz the power, 2011-06-29 00:50:19]

Can't apply patch for file chrome_frame/test/data/simple_object_focus.html.
While running svn propset svn:eol-style LF
chrome_frame/test/data/simple_object_focus.html --config-dir
/mnt/data/b/commit-queue/subversion_config --non-interactive;
patching file chrome_frame/test/data/simple_object_focus.html
svn: File 'chrome_frame/test/data/simple_object_focus.html' has inconsistent
newlines
svn: Inconsistent line ending style

[commit-bot: I haz the power, 2011-06-29 00:53:07]

Can't apply patch for file chrome_frame/test/data/simple_object_focus.html.
While running patch -p0 --forward --force;
patching file chrome_frame/test/data/simple_object_focus.html
Hunk #2 FAILED at 83.
1 out of 2 hunks FAILED -- saving rejects to file
chrome_frame/test/data/simple_object_focus.html.rej

[commit-bot: I haz the power, 2011-06-29 02:29:55]

Change committed as 90914

[memy, 2012-08-15 08:51:05]

memyi04@ovi.com

[memy, 2012-08-15 08:54:50]

lgtm

[memy, 2012-08-15 13:09:58]

Hi my firend  my name is memy     memyi04@ovi.com