Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome_frame/external_tab.h

Issue 7276037: Remove NPAPI support from Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_FRAME_EXTERNAL_TAB_H_ 5 #ifndef CHROME_FRAME_EXTERNAL_TAB_H_
6 #define CHROME_FRAME_EXTERNAL_TAB_H_ 6 #define CHROME_FRAME_EXTERNAL_TAB_H_
7 #pragma once 7 #pragma once
8 8
9 #include <windows.h> 9 #include <windows.h>
10 #include <atlbase.h> 10 #include <atlbase.h>
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 bool is_incognito; 70 bool is_incognito;
71 bool is_widget_mode; 71 bool is_widget_mode;
72 GURL url; 72 GURL url;
73 GURL referrer; 73 GURL referrer;
74 }; 74 };
75 75
76 class NavigationConstraints; 76 class NavigationConstraints;
77 77
78 ///////////////////////////////////////////////////////////////////////// 78 /////////////////////////////////////////////////////////////////////////
79 // ExternalTabProxy is a mediator between ChromeProxy (which runs mostly in 79 // ExternalTabProxy is a mediator between ChromeProxy (which runs mostly in
80 // background IPC-channel thread and the UI object (ActiveX, NPAPI, 80 // background IPC-channel thread and the UI object (ActiveX, ActiveDocument).
robertshield 2011/06/28 20:49:35 nit: *the background, also there is a parentheses
grt (UTC plus 2) 2011/06/28 20:57:38 Done.
81 // ActiveDocument).
82 // The lifetime of ExternalTabProxy is determined by the UI object. 81 // The lifetime of ExternalTabProxy is determined by the UI object.
83 // 82 //
84 // When ExternalTabProxy dies: 83 // When ExternalTabProxy dies:
85 // 1. Remove itself as a ChromeProxyDelegate. This blocks until _Disconnected() 84 // 1. Remove itself as a ChromeProxyDelegate. This blocks until _Disconnected()
86 // is received. 85 // is received.
87 // 2. Kills all posted tasks to the UI thread. 86 // 2. Kills all posted tasks to the UI thread.
88 // 3. Stop all network requests 87 // 3. Stop all network requests
89 // => It does not have to (and should not) be a refcount-ed object. 88 // => It does not have to (and should not) be a refcount-ed object.
90 89
91 // Non-public inheritance is not allowed by the style-guide. 90 // Non-public inheritance is not allowed by the style-guide.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 GURL url; 218 GURL url;
220 GURL referrer; 219 GURL referrer;
221 void Set(const GURL& gurl, const GURL& ref) { 220 void Set(const GURL& gurl, const GURL& ref) {
222 url = gurl; 221 url = gurl;
223 referrer = ref; 222 referrer = ref;
224 } 223 }
225 } pending_navigation_; 224 } pending_navigation_;
226 }; 225 };
227 226
228 #endif // CHROME_FRAME_EXTERNAL_TAB_H_ 227 #endif // CHROME_FRAME_EXTERNAL_TAB_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698