Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 7276032: Make ChromiumStatus work with 0.8.4. (Closed)

Created:
9 years, 5 months ago by cmp
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/build
Visibility:
Public.

Description

Make ChromiumStatus work with 0.8.4. BUG=79195 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90780

Patch Set 1 #

Patch Set 2 : fix copyright, comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -10 lines) Patch
M scripts/master/chromium_status.py View 1 4 chunks +23 lines, -3 lines 0 comments Download
M scripts/master/master_utils.py View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/buildbot_8_4p1/README.chromium View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/changes.py View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
cmp
9 years, 5 months ago (2011-06-28 10:59:59 UTC) #1
nsylvain
LGTM http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html File third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html (right): http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html#newcode70 third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html:70: {% macro box_contents(who, url, pageTitle, revision) -%} Have ...
9 years, 5 months ago (2011-06-28 16:50:13 UTC) #2
cmp
http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html File third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html (right): http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html#newcode70 third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html:70: {% macro box_contents(who, url, pageTitle, revision) -%} On 2011/06/28 ...
9 years, 5 months ago (2011-06-28 16:54:18 UTC) #3
commit-bot: I haz the power
9 years, 5 months ago (2011-06-28 16:55:21 UTC) #4
Change committed as 90780

Powered by Google App Engine
This is Rietveld 408576698