Make ChromiumStatus work with 0.8.4.

Make ChromiumStatus work with 0.8.4.

BUG=79195
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90780

[nsylvain, 2011-06-28 16:50:13]

LGTM

http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/b...
File third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html
(right):

http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/b...
third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html:70:
{% macro box_contents(who, url, pageTitle, revision) -%}
Have you considered making this change in public_html instead?  (I think if a
template has the same name, the template in public_html takes over)

[cmp, 2011-06-28 16:54:18]

http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/b...
File third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html
(right):

http://codereview.chromium.org/7276032/diff/1006/third_party/buildbot_8_4p1/b...
third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.html:70:
{% macro box_contents(who, url, pageTitle, revision) -%}
On 2011/06/28 16:50:13, nsylvain wrote:
> Have you considered making this change in public_html instead?  (I think if a
> template has the same name, the template in public_html takes over)

I didn't consider it, but that's mostly because this seemed like the right place
to me.  Making it in Buildbot seemed to make more sense since all of the masters
were using the chromium_status module before and this way they all pick up the
revision without needing to copy another template into their public_html/
directories.  The macro requires a change in Buildbot to support passing in the
change revision, too.  I think here is the right place.

[commit-bot: I haz the power, 2011-06-28 16:55:21]

Change committed as 90780