Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: third_party/buildbot_8_4p1/README.chromium

Issue 7276032: Make ChromiumStatus work with 0.8.4. (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/build
Patch Set: fix copyright, comment Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 URL: http://buildbot.net/trac 1 URL: http://buildbot.net/trac
2 Version: 0.8.4p1 2 Version: 0.8.4p1
3 License: GNU General Public License (GPL) Version 2 3 License: GNU General Public License (GPL) Version 2
4 4
5 This is a forked copy of buildbot v0.8.4p1. 5 This is a forked copy of buildbot v0.8.4p1.
6 6
7 7
8 Add extra parameters to HttpStatusPush as a very basic authentication mechanism. 8 Add extra parameters to HttpStatusPush as a very basic authentication mechanism.
9 9
10 diff --git a/third_party/buildbot_8_4p1/buildbot/status/status_push.py b/third_p arty/buildbot_8_4p1/buildbot/status/status_push.py 10 diff --git a/third_party/buildbot_8_4p1/buildbot/status/status_push.py b/third_p arty/buildbot_8_4p1/buildbot/status/status_push.py
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 template = templates.get_template("console.html") 333 template = templates.get_template("console.html")
334 data = template.render(cxt) 334 data = template.render(cxt)
335 + 335 +
336 + # Clean up the cache. 336 + # Clean up the cache.
337 + if debugInfo["added_blocks"]: 337 + if debugInfo["added_blocks"]:
338 + self.cache.trim() 338 + self.cache.trim()
339 + 339 +
340 return data 340 return data
341 d.addCallback(got_changes) 341 d.addCallback(got_changes)
342 return d 342 return d
343
344
345 Add revision to changes in the waterfall.
346
347 diff --git a/third_party/buildbot_8_4p1/buildbot/status/web/changes.py b/third_p arty/buildbo
348 index 415e781..a15dff8 100644
349 --- a/third_party/buildbot_8_4p1/buildbot/status/web/changes.py
350 +++ b/third_party/buildbot_8_4p1/buildbot/status/web/changes.py
351 @@ -63,7 +63,8 @@ class ChangeBox(components.Adapter):
352 template = req.site.buildbot_service.templates.get_template("change_mac ros.html")
353 text = template.module.box_contents(url=url,
354 who=self.original.getShortAuthor(),
355 - pageTitle=self.original.comments)
356 + pageTitle=self.original.comments,
357 + revision=self.original.revision)
358 return Box([text], class_="Change")
359 components.registerAdapter(ChangeBox, Change, IBox)
360
361 diff --git a/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_mac ros.html b/t
362 index b9b7780..9a37b47 100644
363 --- a/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.htm l
364 +++ b/third_party/buildbot_8_4p1/buildbot/status/web/templates/change_macros.htm l
365 @@ -67,6 +67,6 @@
366 {% endif %}
367 {%- endmacro %}
368
369 -{% macro box_contents(who, url, pageTitle) -%}
370 -<a href="{{ url }}" title="{{ pageTitle|e }}">{{ who|user }}</a>
371 +{% macro box_contents(who, url, pageTitle, revision) -%}
372 +<a href="{{ url }}" title="{{ pageTitle|e }}">{{ who|user }}</a><br>r{{ revisio n }}
373 {%- endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698