Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 727523002: IDL: Use raw pointers instead of RawPtr<> for rvalue types (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Use raw pointers instead of RawPtr<> for rvalue types For unconditionally garbage collected types, use of RawPtr<> is unnecessary. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185425

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jens Widell
PTAL As suggested in https://codereview.chromium.org/714123002/. Getting rid of all plain use of RawPtr<> in generated ...
6 years, 1 month ago (2014-11-13 17:04:11 UTC) #3
sof
(non-owner) lgtm. (Kick off some trybots to verify buildability?)
6 years, 1 month ago (2014-11-13 17:40:26 UTC) #4
haraken
LGTM
6 years, 1 month ago (2014-11-14 00:35:26 UTC) #5
haraken
> Getting rid of all plain use of RawPtr<> in generated code would be possible, ...
6 years, 1 month ago (2014-11-14 00:38:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/727523002/20001
6 years, 1 month ago (2014-11-17 07:10:12 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 09:23:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 185425

Powered by Google App Engine
This is Rietveld 408576698