Source/bindings/scripts/v8_types.py - Issue 727523002: IDL: Use raw pointers instead of RawPtr<> for rvalue types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 727523002: IDL: Use raw pointers instead of RawPtr<> for rvalue types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index 5b7eac40f1914cc62ba2ce2cb19bb3944aaf53ee..c210a36908bcddc1390056b7a45bf13b218487c7 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -185,7 +185,7 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_rvalue_

return idl_type.implemented_as + '*'

if idl_type.is_interface_type:

implemented_as_class = idl_type.implemented_as

- if raw_type:

+ if raw_type or (used_as_rvalue_type and idl_type.is_garbage_collected):

return implemented_as_class + '*'

new_type = 'Member' if used_in_cpp_sequence else 'RawPtr'

ptr_type = cpp_ptr_type(('PassRefPtr' if used_as_rvalue_type else 'RefPtr'), new_type, idl_type.gc_type)

« no previous file with comments | « no previous file | Source/bindings/tests/results/core/TestDictionary.h » ('j') | no next file with comments »