Merge 89635 - 2011-06-23 John Bates <jbates@google.com>

Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 102 matching lines @@
 LayerRendererChromium::LayerRendererChromium(PassRefPtr<GraphicsContext3D> context,
                                              PassOwnPtr<LayerPainterChromium> contentPaint,
                                              bool accelerateDrawing)
     : m_viewportScrollPosition(IntPoint(-1, -1))
     , m_rootLayer(0)
     , m_accelerateDrawing(accelerateDrawing)
     , m_currentRenderSurface(0)
     , m_offscreenFramebufferId(0)
     , m_compositeOffscreen(false)
     , m_context(context)
-    , m_childContextsWereCopied(false)
     , m_contextSupportsLatch(false)
     , m_animating(false)
     , m_defaultRenderSurface(0)
 {
     m_contextSupportsLatch = m_context->getExtensions()->supports("GL_CHROMIUM_latch");
     m_contextSupportsMapSub = m_context->getExtensions()->supports("GL_CHROMIUM_map_sub");
     if (m_contextSupportsMapSub)
         m_context->getExtensions()->ensureEnabled("GL_CHROMIUM_map_sub");
     m_hardwareCompositing = initializeSharedObjects();
 
@@ skipping 104 matching lines @@
     LayerList renderSurfaceLayerList;
     updateLayers(renderSurfaceLayerList);
 
     // Before drawLayers:
     if (hardwareCompositing() && m_contextSupportsLatch) {
         // FIXME: The multithreaded compositor case will not work as long as
         // copyTexImage2D resolves to the parent texture, because the main
         // thread can execute WebGL calls on the child context at any time,
         // potentially clobbering the parent texture that is being renderered
         // by the compositor thread.
-        if (m_childContextsWereCopied) {
-            Extensions3DChromium* parentExt = static_cast<Extensions3DChromium*>(m_context->getExtensions());
-            // For each child context:
-            //   glWaitLatch(Offscreen->Compositor);
-            ChildContextMap::iterator i = m_childContexts.begin();
-            for (; i != m_childContexts.end(); ++i) {
-                Extensions3DChromium* childExt = static_cast<Extensions3DChromium*>(i->first->getExtensions());
-                GC3Duint latchId;
-                childExt->getChildToParentLatchCHROMIUM(&latchId);
-                parentExt->waitLatchCHROMIUM(latchId);
+        Extensions3DChromium* parentExt = static_cast<Extensions3DChromium*>(m_context->getExtensions());
+        // For each child context:
+        //   glWaitLatch(Offscreen->Compositor);
+        ChildContextMap::iterator i = m_childContexts.begin();
+        for (; i != m_childContexts.end(); ++i) {
+            Extensions3DChromium* childExt = static_cast<Extensions3DChromium*>(i->first->getExtensions());
+            if (childExt->getGraphicsResetStatusARB() == GraphicsContext3D::NO_ERROR) {
+                GC3Duint childToParentLatchId;
+                childExt->getChildToParentLatchCHROMIUM(&childToParentLatchId);
+                childExt->setLatchCHROMIUM(childToParentLatchId);
+                parentExt->waitLatchCHROMIUM(childToParentLatchId);
             }
         }
-        // Reset to false to indicate that we have consumed the dirty child
-        // contexts' parent textures. (This is only useful when the compositor
-        // is multithreaded.)
-        m_childContextsWereCopied = false;
     }
 
     drawLayers(renderSurfaceLayerList);
 
     m_textureManager->unprotectAllTextures();
 
     // After drawLayers:
     if (hardwareCompositing() && m_contextSupportsLatch) {
         Extensions3DChromium* parentExt = static_cast<Extensions3DChromium*>(m_context->getExtensions());
         // For each child context:
         //   glSetLatch(Compositor->Offscreen);
         ChildContextMap::iterator i = m_childContexts.begin();
         for (; i != m_childContexts.end(); ++i) {
             Extensions3DChromium* childExt = static_cast<Extensions3DChromium*>(i->first->getExtensions());
-            GC3Duint latchId;
-            childExt->getParentToChildLatchCHROMIUM(&latchId);
-            parentExt->setLatchCHROMIUM(latchId);
+            if (childExt->getGraphicsResetStatusARB() == GraphicsContext3D::NO_ERROR) {
+                GC3Duint parentToChildLatchId;
+                childExt->getParentToChildLatchCHROMIUM(&parentToChildLatchId);
+                parentExt->setLatchCHROMIUM(parentToChildLatchId);
+                childExt->waitLatchCHROMIUM(parentToChildLatchId);
+            }
         }
     }
 
     if (isCompositingOffscreen())
         copyOffscreenTextureToDisplay();
 }
 
 PassOwnPtr<LayerTextureUpdater> LayerRendererChromium::createRootLayerTextureUpdater(PassOwnPtr<LayerPainterChromium> painter)
 {
 #if USE(SKIA)
@@ skipping 32 matching lines @@
     updatePropertiesAndRenderSurfaces(rootDrawLayer, identityMatrix, renderSurfaceLayerList, m_defaultRenderSurface->m_layerList);
 
 #ifndef NDEBUG
     s_inPaintLayerContents = true;
 #endif
     paintLayerContents(renderSurfaceLayerList);
 #ifndef NDEBUG
     s_inPaintLayerContents = false;
 #endif
 
-    // FIXME: Before updateCompositorResources, when the compositor runs in
-    // its own thread, and when the copyTexImage2D bug is fixed, insert
-    // a glWaitLatch(Compositor->Offscreen) on all child contexts here instead
-    // of after updateCompositorResources.
-    // Also uncomment the glSetLatch(Compositor->Offscreen) code in addChildContext.
-//  if (hardwareCompositing() && m_contextSupportsLatch) {
-//      // For each child context:
-//      //   glWaitLatch(Compositor->Offscreen);
-//      ChildContextMap::iterator i = m_childContexts.begin();
-//      for (; i != m_childContexts.end(); ++i) {
-//          Extensions3DChromium* ext = static_cast<Extensions3DChromium*>(i->first->getExtensions());
-//          GC3Duint childToParentLatchId, parentToChildLatchId;
-//          ext->getParentToChildLatchCHROMIUM(&parentToChildLatchId);
-//          ext->waitLatchCHROMIUM(parentToChildLatchId);
-//      }
-//  }
-
     updateCompositorResources(renderSurfaceLayerList);
     // Update compositor resources for root layer.
     m_rootLayerContentTiler->updateRect();
-
-    // After updateCompositorResources, set/wait latches for all child
-    // contexts. This will prevent the compositor from using any of the child
-    // parent textures while WebGL commands are executing from javascript *and*
-    // while the final parent texture is being blit'd. copyTexImage2D
-    // uses the parent texture as a temporary resolve buffer, so that's why the
-    // waitLatch is below, to block the compositor from using the parent texture
-    // until the next WebGL SwapBuffers (or copyTextureToParentTexture for
-    // Canvas2D).
-    if (hardwareCompositing() && m_contextSupportsLatch) {
-        m_childContextsWereCopied = true;
-        // For each child context:
-        //   glSetLatch(Offscreen->Compositor);
-        //   glWaitLatch(Compositor->Offscreen);
-        ChildContextMap::iterator i = m_childContexts.begin();
-        for (; i != m_childContexts.end(); ++i) {
-            Extensions3DChromium* ext = static_cast<Extensions3DChromium*>(i->first->getExtensions());
-            GC3Duint childToParentLatchId, parentToChildLatchId;
-            ext->getParentToChildLatchCHROMIUM(&parentToChildLatchId);
-            ext->getChildToParentLatchCHROMIUM(&childToParentLatchId);
-            ext->setLatchCHROMIUM(childToParentLatchId);
-            ext->waitLatchCHROMIUM(parentToChildLatchId);
-        }
-    }
 }
 
 void LayerRendererChromium::paintLayerContents(const LayerList& renderSurfaceLayerList)
 {
     for (int surfaceIndex = renderSurfaceLayerList.size() - 1; surfaceIndex >= 0 ; --surfaceIndex) {
         CCLayerImpl* renderSurfaceLayer = renderSurfaceLayerList[surfaceIndex].get();
         RenderSurfaceChromium* renderSurface = renderSurfaceLayer->renderSurface();
         ASSERT(renderSurface);
 
         // Make sure any renderSurfaceLayer is associated with this layerRenderer.
@@ skipping 791 matching lines @@
         if (--i->second <= 0) {
             // Count reached zero, so remove from map.
             m_childContexts.remove(i);
         }
     } else {
         // error
         ASSERT(0 && "m_childContexts map has mismatched add/remove calls");
     }
 }
 
+bool LayerRendererChromium::isCompositorContextLost()
+{
+    return (m_context.get()->getExtensions()->getGraphicsResetStatusARB() != GraphicsContext3D::NO_ERROR);
+}
+
 void LayerRendererChromium::dumpRenderSurfaces(TextStream& ts, int indent, LayerChromium* layer) const
 {
     if (layer->ccLayerImpl()->renderSurface())
         layer->ccLayerImpl()->renderSurface()->dumpSurface(ts, indent);
 
     for (size_t i = 0; i < layer->children().size(); ++i)
         dumpRenderSurfaces(ts, indent, layer->children()[i].get());
 }
 
 } // namespace WebCore
 
 #endif // USE(ACCELERATED_COMPOSITING)