Issue 7273043: Added last_modified to Search Engines specifics protobuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7273043: Added last_modified to Search Engines specifics protobuffer. (Closed)

Created:
9 years, 5 months ago by SteveT

Modified:
9 years, 5 months ago

Reviewers:
commit-bot: I haz the power, Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Added last_modified to Search Engines specifics protobuffer. TEST=None BUG=15548 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90841

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/sync/protocol/proto_value_conversions.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/sync/protocol/search_engine_specifics.proto	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

SteveT

Hey Nick, could you take a quick look at this? Thanks! Steve

9 years, 5 months ago (2011-06-28 20:49:43 UTC) #1

commit-bot: I haz the power

9 years, 5 months ago (2011-06-28 21:03:04 UTC) #3

Can't apply patch for file
chrome/browser/sync/protocol/search_engine_specifics.proto.
While running patch -p0 --forward --force;
patching file chrome/browser/sync/protocol/search_engine_specifics.proto
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/sync/protocol/search_engine_specifics.proto.rej

Expand Messages | Collapse Messages