Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 726933006: Explicitly declare mojo_application_base->mojom dep in gyp (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Explicitly declare mojo_application_base->mojom dep in gyp mojo/public/cpp/application/application_connection.h includes service_provider.mojom.h, so it must explicitly declare a hard dependency in gyp on the mojom target that produces this header or the header might not exist on disk when targets that include application_connection.h are compiled. This does so by exporting the application_bindings_mojom dependent settings (which includes the hard_dependency bit) from mojo_application_bindings, which mojo_application_base depends on and exports. (port of https://codereview.chromium.org/733513003) TBR=viettrungluu@chromium.org

Patch Set 1 #

Patch Set 2 : different deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/public/mojo_public.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jamesr
6 years, 1 month ago (2014-11-14 21:23:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726933006/1
6 years, 1 month ago (2014-11-14 21:23:43 UTC) #3
viettrungluu
lgtm
6 years, 1 month ago (2014-11-14 21:38:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/28520)
6 years, 1 month ago (2014-11-14 21:50:55 UTC) #6
jamesr
OK that didn't link on android or windows. PTAL
6 years, 1 month ago (2014-11-14 22:58:39 UTC) #7
jamesr
6 years, 1 month ago (2014-11-15 00:53:09 UTC) #8
OK, this has green try runs but the underlying mojo roll was reverted in
chromium.  Will land this in mojo and then roll with the rest of it.

Powered by Google App Engine
This is Rietveld 408576698