Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 733513003: Explicitly declare mojo_application_base->mojom dep in gyp (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Explicitly declare mojo_application_base->mojom dep in gyp mojo/public/cpp/application/application_connection.h includes service_provider.mojom.h, so it must explicitly declare a hard dependency in gyp on the mojom target that produces this header or the header might not exist on disk when targets that include application_connection.h are compiled. This does so by exporting the application_bindings_mojom dependent settings (which includes the hard_dependency bit) from mojo_application_bindings, which mojo_application_base depends on and exports. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8cc08a77b4695487e61b4ef42b8160c1b19a564b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M mojo/public/mojo_public.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jamesr
6 years, 1 month ago (2014-11-14 21:21:30 UTC) #2
viettrungluu
lgtm
6 years, 1 month ago (2014-11-14 21:21:45 UTC) #3
jamesr
6 years, 1 month ago (2014-11-14 21:22:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8cc08a77b4695487e61b4ef42b8160c1b19a564b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698