include/utils/SkCamera.h - Issue 726923002: Enable unused param checking for public includes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/utils/SkCamera.h

Issue 726923002: Enable unused param checking for public includes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix errors Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/utils/SkCamera.h

diff --git a/include/utils/SkCamera.h b/include/utils/SkCamera.h

index b515be9c6cfeec698fed90997547a9f6dc0b0564..4b77ec685d38a18e6f32e0c3e300399676ee8f10 100644

--- a/include/utils/SkCamera.h

+++ b/include/utils/SkCamera.h

@@ -84,8 +84,8 @@ public:

}

// deprecated, but still here for animator (for now)

- void rotate(SkScalar x, SkScalar y, SkScalar z) {}

- void rotateDegrees(SkScalar x, SkScalar y, SkScalar z) {}

+ void rotate(SkScalar /*x*/, SkScalar /*y*/, SkScalar /*z*/) {}

+ void rotateDegrees(SkScalar /*x*/, SkScalar /*y*/, SkScalar /*z*/) {}

private:

public: // make public for SkDraw3D for now