Chromium Code Reviews| Index: include/ports/SkFontMgr.h |
| diff --git a/include/ports/SkFontMgr.h b/include/ports/SkFontMgr.h |
| index bc4e1abb3a70208501a268b0a20f3fc818d27e12..480c17d704e7b94e0090970d34025d4533aa7f65 100644 |
| --- a/include/ports/SkFontMgr.h |
| +++ b/include/ports/SkFontMgr.h |
| @@ -121,11 +121,9 @@ protected: |
| virtual SkTypeface* onMatchFamilyStyle(const char familyName[], |
| const SkFontStyle&) const = 0; |
| - // TODO: pure virtual, implement on all impls. |
| virtual SkTypeface* onMatchFamilyStyleCharacter(const char familyName[], const SkFontStyle&, |
| const char* bcp47[], int bcp47Count, |
| - SkUnichar character) const |
| - { return NULL; } |
| + SkUnichar character) const = 0; |
|
mtklein
2014/11/14 16:30:15
This seems like something you might want to spin o
djsollen
2014/11/14 18:55:23
https://codereview.chromium.org/728873002/
|
| virtual SkTypeface* onMatchFaceStyle(const SkTypeface*, |
| const SkFontStyle&) const = 0; |