Enable DirectWrite for font metrics and font rendering in Chrome UI on Windows by default.

Enable DirectWrite for font metrics and font rendering in Chrome UI on Windows by default.

We have a switch --disable-directwrite-for-ui to switch back to GDI.

BUG=389649
Committed: https://crrev.com/e047d110147f0d207aa84b567a1b2f8734294dcc
Cr-Commit-Position: refs/heads/master@{#304487}

[ananta, 2014-11-15 00:29:00]

ananta@chromium.org changed reviewers:
+ cpu@chromium.org, sky@chromium.org

[sky, 2014-11-17 15:44:16]

https://codereview.chromium.org/726893005/diff/1/ui/gfx/switches.cc
File ui/gfx/switches.cc (right):

https://codereview.chromium.org/726893005/diff/1/ui/gfx/switches.cc#newcode28
ui/gfx/switches.cc:28: const char kDisableDirectWriteForUI[] =
"disable-directwrite-for-ui";
Do we really need both DisableDirectWrite and DisableDirectWriteForUI?

[ananta, 2014-11-17 19:38:25]

On 2014/11/17 15:44:16, sky wrote:
> https://codereview.chromium.org/726893005/diff/1/ui/gfx/switches.cc
> File ui/gfx/switches.cc (right):
> 
> https://codereview.chromium.org/726893005/diff/1/ui/gfx/switches.cc#newcode28
> ui/gfx/switches.cc:28: const char kDisableDirectWriteForUI[] =
> "disable-directwrite-for-ui";
> Do we really need both DisableDirectWrite and DisableDirectWriteForUI?

We don't ideally. However the DisableDirectWrite switch turns off DirectWrite
for the renderer processes.
Given that the DirectWrite stuff for the renderer processes has been in the wild
for a while, wanted to keep
them separate. Once we ship this to stable we can consolidate both switches.

[sky, 2014-11-17 20:34:24]

Ok, LGTM

[cpu_(ooo_6.6-7.5), 2014-11-17 21:01:16]

lgtm

[ananta, 2014-11-17 21:04:40]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-11-17 21:05:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/726893005/1

[commit-bot: I haz the power, 2014-11-17 21:51:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-17 21:52:37]

Patchset 1 (id:??) landed as
https://crrev.com/e047d110147f0d207aa84b567a1b2f8734294dcc
Cr-Commit-Position: refs/heads/master@{#304487}

[lordfeyi, 2015-03-20 04:21:55]

On 2014/11/17 21:52:37, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e047d110147f0d207aa84b567a1b2f8734294dcc
> Cr-Commit-Position: refs/heads/master@{#304487}

Doesn't work for chrome in Windows 8 mode though.

[lordfeyi, 2015-03-20 06:27:49]

feyizee@gmail.com changed reviewers:
+ feyizee@gmail.com

[lordfeyi, 2015-03-20 06:27:52]

lgtm

[aophisoka, 2017-08-22 13:49:43]

On 2015/03/20 06:27:52, lordfeyi wrote:
> lgtm