Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3760)

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 726813002: [Extensions Toolbar] Make the ExtensionToolbarModel icon count more stable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
index 3970f9680416324f42a071a1067e8cabcdb95bad..9ede3a62d5ffa0a3c7ec803922a69cae71559a0e 100644
--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
@@ -152,6 +152,7 @@ class ToolbarActionsBarBridge : public ToolbarActionsBarDelegate {
private:
// ToolbarActionsBarDelegate:
+ bool IsReady() const override;
void AddViewForAction(ToolbarActionViewController* action,
size_t index) override;
void RemoveViewForAction(ToolbarActionViewController* action) override;
@@ -181,6 +182,12 @@ ToolbarActionsBarBridge::ToolbarActionsBarBridge(
ToolbarActionsBarBridge::~ToolbarActionsBarBridge() {
}
+bool ToolbarActionsBarBridge::IsReady() const {
+ // Unlike the ui/views implementation, the BrowserActionsController is ready
+ // to create views from the time of its construction.
+ return true;
+}
+
void ToolbarActionsBarBridge::AddViewForAction(
ToolbarActionViewController* action,
size_t index) {

Powered by Google App Engine
This is Rietveld 408576698