[Extensions Toolbar] Make the ExtensionToolbarModel icon count more stable

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/strings/sys_string_conversions.h"
@@ skipping 134 matching lines @@
 namespace {
 
 // A bridge between the ToolbarActionsBar and the BrowserActionsController.
 class ToolbarActionsBarBridge : public ToolbarActionsBarDelegate {
  public:
   explicit ToolbarActionsBarBridge(BrowserActionsController* controller);
   ~ToolbarActionsBarBridge() override;
 
  private:
   // ToolbarActionsBarDelegate:
+  bool IsReady() const override;
   void AddViewForAction(ToolbarActionViewController* action,
                         size_t index) override;
   void RemoveViewForAction(ToolbarActionViewController* action) override;
   void RemoveAllViews() override;
   void Redraw(bool order_changed) override;
   void ResizeAndAnimate(gfx::Tween::Type tween_type,
                         int target_width,
                         bool suppress_chevron) override;
   void SetChevronVisibility(bool chevron_visible) override;
   int GetWidth() const override;
   bool IsAnimating() const override;
   void StopAnimating() override;
   int GetChevronWidth() const override;
   bool IsPopupRunning() const override;
 
   // The owning BrowserActionsController; weak.
   BrowserActionsController* controller_;
 
   DISALLOW_COPY_AND_ASSIGN(ToolbarActionsBarBridge);
 };
 
 ToolbarActionsBarBridge::ToolbarActionsBarBridge(
     BrowserActionsController* controller)
     : controller_(controller) {
 }
 
 ToolbarActionsBarBridge::~ToolbarActionsBarBridge() {
 }
 
+bool ToolbarActionsBarBridge::IsReady() const {
+  // Unlike the ui/views implementation, the BrowserActionsController is ready
+  // to create views from the time of its construction.
+  return true;
+}
+
 void ToolbarActionsBarBridge::AddViewForAction(
     ToolbarActionViewController* action,
     size_t index) {
   [controller_ addViewForAction:action
                       withIndex:index];
 }
 
 void ToolbarActionsBarBridge::RemoveViewForAction(
     ToolbarActionViewController* action) {
   [controller_ removeViewForAction:action];
@@ skipping 560 matching lines @@
 
 - (BrowserActionButton*)buttonWithIndex:(NSUInteger)index {
   const std::vector<ToolbarActionViewController*>& toolbar_actions =
       toolbarActionsBar_->toolbar_actions();
   if (index < toolbar_actions.size())
     return [self buttonForId:toolbar_actions[index]->GetId()];
   return nil;
 }
 
 @end