Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 726703006: Add a note in other.html for not merging it with done.html (Closed)

Created:
6 years, 1 month ago by Sunil Ratnu
Modified:
6 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a note in other.html for not merging it with done.html This is a follow up CL as per comments in https://codereview.chromium.org/733953002/diff/120001/chrome/test/data/password/other.html We should not merge other.html file with done.html because test PromptAfterSubmitWithSubFrameNavigation needs two such files, with different filenames. BUG=432592 Committed: https://crrev.com/c570475ba3a741770baa3a63c2530a8c7d52fbb3 Cr-Commit-Position: refs/heads/master@{#304800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/data/password/other.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sunil Ratnu
6 years, 1 month ago (2014-11-19 11:22:11 UTC) #2
Sunil Ratnu
Hi Vaclav, Please have a look. Thanks! Sunil
6 years, 1 month ago (2014-11-19 11:22:52 UTC) #3
vabr (Chromium)
LGTM, thanks!
6 years, 1 month ago (2014-11-19 12:47:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726703006/1
6 years, 1 month ago (2014-11-19 12:52:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 13:50:31 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 13:51:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c570475ba3a741770baa3a63c2530a8c7d52fbb3
Cr-Commit-Position: refs/heads/master@{#304800}

Powered by Google App Engine
This is Rietveld 408576698