Issue 726483002: Files.app: Use "ready" message instead of "worker-initialized" for waiting initialization in Select…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 726483002: Files.app: Use "ready" message instead of "worker-initialized" for waiting initialization in Select… (Closed)

Created:
6 years, 1 month ago by hirono

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Use "ready" message instead of "worker-initialized" for waiting initialization in SelectFileAndCancel test. The current message "worker-initialized" does not ensure the whole initialize process completed in Files.app, and it causes races in the test after the refactoring of crbug.com/267281. BUG=432029 TEST=Run SelectFileAndCancel TBR=sky Review URL: https://codereview.chromium.org/714813002 Cr-Commit-Position: refs/heads/master@{#303788} (cherry picked from commit 8866b6d59454363b687d8c6b099d6c663a78d66c) Committed: https://chromium.googlesource.com/chromium/src/+/6ab35baed6e1f6f7184ff284c3261ed1c5cc60ed

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc	View		3 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

hirono

6 years, 1 month ago (2014-11-13 08:08:59 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6ab35baed6e1f6f7184ff284c3261ed1c5cc60ed (presubmit successful).

Expand Messages | Collapse Messages