Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 714813002: Files.app: Use "ready" message for waiting initialization in SelectFileAndCancel test. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
sky, yawano
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Use "ready" message instead of "worker-initialized" for waiting initialization in SelectFileAndCancel test. The current message "worker-initialized" does not ensure the whole initialize process completed in Files.app, and it causes races in the test after the refactoring of crbug.com/267281. BUG=432029 TEST=Run SelectFileAndCancel Committed: https://crrev.com/8866b6d59454363b687d8c6b099d6c663a78d66c Cr-Commit-Position: refs/heads/master@{#303788}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
hirono
PTAL the CL? Thanks!
6 years, 1 month ago (2014-11-11 07:29:43 UTC) #2
yawano
lgtm.
6 years, 1 month ago (2014-11-11 08:01:58 UTC) #3
hirono
On 2014/11/11 08:01:58, yawano wrote: > lgtm. Thanks!
6 years, 1 month ago (2014-11-11 09:38:33 UTC) #6
hirono
@sky - PTAL the CL? Thanks!
6 years, 1 month ago (2014-11-11 09:40:22 UTC) #8
sky
LGTM
6 years, 1 month ago (2014-11-11 16:52:15 UTC) #9
hirono
On 2014/11/11 16:52:15, sky wrote: > LGTM Thanks!
6 years, 1 month ago (2014-11-12 04:01:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714813002/10002
6 years, 1 month ago (2014-11-12 04:02:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:10002)
6 years, 1 month ago (2014-11-12 04:46:04 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 04:46:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8866b6d59454363b687d8c6b099d6c663a78d66c
Cr-Commit-Position: refs/heads/master@{#303788}

Powered by Google App Engine
This is Rietveld 408576698