Issue 726473002: Files.app: Add a check for uninitialized list view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 726473002: Files.app: Add a check for uninitialized list view. (Closed)

Created:
6 years, 1 month ago by hirono

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

Files.app: Add a check for uninitialized list view. The check is needed in relayout method of FileManagerUI. The list view may be not initialized. BUG=432025 TEST=None TBR=fukino Review URL: https://codereview.chromium.org/712323002 Cr-Commit-Position: refs/heads/master@{#303607} (cherry picked from commit ed2ca7c12653002df2729bd190a52df48a992895) Committed: https://chromium.googlesource.com/chromium/src/+/e286b498b1b32d7f6335bad08308d6fa4e6147ba

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

hirono

6 years, 1 month ago (2014-11-13 07:58:25 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e286b498b1b32d7f6335bad08308d6fa4e6147ba (presubmit successful).