Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 712323002: Files.app: Add a check for uninitialized list view. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add a check for uninitialized list view. The check is needed in relayout method of FileManagerUI. The list view may be not initialized. BUG=432025 TEST=None Committed: https://crrev.com/ed2ca7c12653002df2729bd190a52df48a992895 Cr-Commit-Position: refs/heads/master@{#303607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thanks!
6 years, 1 month ago (2014-11-11 07:10:20 UTC) #2
fukino
On 2014/11/11 07:10:20, hirono wrote: > PTAL the CL? Thanks! lgtm!
6 years, 1 month ago (2014-11-11 07:15:29 UTC) #3
hirono
On 2014/11/11 07:15:29, fukino wrote: > On 2014/11/11 07:10:20, hirono wrote: > > PTAL the ...
6 years, 1 month ago (2014-11-11 07:30:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712323002/1
6 years, 1 month ago (2014-11-11 07:30:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 08:16:10 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 08:16:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed2ca7c12653002df2729bd190a52df48a992895
Cr-Commit-Position: refs/heads/master@{#303607}

Powered by Google App Engine
This is Rietveld 408576698