Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 726313007: Add the ability to upload sky_tests to the flakiness dashboard. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
jamesr, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add the ability to upload sky_tests to the flakiness dashboard. Modify mojob.py to plumb through the arguments needed to upload sky tests to the flakiness dashboard. A followup change will need to modify the buildbot side to pass these arguments to mojob.py. R=abarth@chromium.org, jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/15874b2a7c327e8b794f59d34bbfb9f321047cd5

Patch Set 1 #

Patch Set 2 : Remove build-name argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M mojo/tools/mojob.py View 1 2 chunks +28 lines, -0 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M sky/tools/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +8 lines, -3 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/run_webkit_tests.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ojan
6 years, 1 month ago (2014-11-17 19:29:02 UTC) #2
ojan
Updated to remove the --build-name argument. Turns out this is no longer used.
6 years, 1 month ago (2014-11-17 20:05:11 UTC) #3
ojan
Here's the buildbot side patch: https://codereview.chromium.org/733203003. Will wait for this to land before sending that ...
6 years, 1 month ago (2014-11-17 20:53:42 UTC) #4
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-17 21:00:32 UTC) #5
jamesr
lgtm
6 years, 1 month ago (2014-11-17 21:01:37 UTC) #6
ojan
6 years, 1 month ago (2014-11-17 21:14:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
15874b2a7c327e8b794f59d34bbfb9f321047cd5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698