Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 733203003: Modify mojo recipe to upload to the flakiness dashboard. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
jamesr, agable, sky
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, pgervais+watch_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Modify mojo recipe to upload to the flakiness dashboard. Add the flags mojob.py needs in order to upload to the flakiness dashboard. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292978

Patch Set 1 #

Total comments: 2

Patch Set 2 : make test-results-server overrideable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M scripts/slave/recipes/mojo.py View 1 1 chunk +8 lines, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux.json View 1 chunk +9 lines, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_linux_dbg.json View 1 chunk +9 lines, -1 line 0 comments Download
M scripts/slave/recipes/mojo.expected/mojo_win_dbg.json View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ojan
6 years, 1 month ago (2014-11-17 21:02:19 UTC) #2
jamesr
lgtm
6 years, 1 month ago (2014-11-17 21:03:02 UTC) #3
agable
LGTM % a suggestion. https://codereview.chromium.org/733203003/diff/1/scripts/slave/recipes/mojo.py File scripts/slave/recipes/mojo.py (right): https://codereview.chromium.org/733203003/diff/1/scripts/slave/recipes/mojo.py#newcode66 scripts/slave/recipes/mojo.py:66: '--test-results-server', 'test-results.appspot.com', Might be nice ...
6 years, 1 month ago (2014-11-17 21:16:13 UTC) #4
ojan
https://codereview.chromium.org/733203003/diff/1/scripts/slave/recipes/mojo.py File scripts/slave/recipes/mojo.py (right): https://codereview.chromium.org/733203003/diff/1/scripts/slave/recipes/mojo.py#newcode66 scripts/slave/recipes/mojo.py:66: '--test-results-server', 'test-results.appspot.com', On 2014/11/17 21:16:13, agable wrote: > Might ...
6 years, 1 month ago (2014-11-17 21:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733203003/20001
6 years, 1 month ago (2014-11-17 21:20:38 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 21:21:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 292978

Powered by Google App Engine
This is Rietveld 408576698