Issue 726143002: Remove FX_LPCWSTR cast to wchar_t* literals

Issue 726143002: Remove FX_LPCWSTR cast to wchar_t* literals (Closed)

Created:
6 years, 1 month ago by Bo Xu

Modified:
6 years, 1 month ago

Reviewers:
Tom Sepez, brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Remove FX_LPCWSTR cast to wchar_t* literals BUG=https://code.google.com/p/pdfium/issues/detail?id=78 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/893fe94f069656ef5106db1aec32ec11b85f4de2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+198 lines, -198 lines)			Patch
M	core/src/fpdfdoc/doc_basic.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/src/fxcrt/fx_xml_parser.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Consts.cpp	View	1 chunk	+38 lines, -38 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	8 chunks	+30 lines, -30 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/JS_EventHandler.cpp	View	3 chunks	+42 lines, -42 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	11 chunks	+31 lines, -31 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.cpp	View	12 chunks	+38 lines, -38 lines	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_Note.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Tom Sepez

LGTM. Please change the description to say BUG=https://code.google.com/p/pdfium/issues/detail?id=78

6 years, 1 month ago (2014-11-15 00:46:28 UTC) #3

Bo Xu

Committed patchset #1 (id:1) manually as 893fe94f069656ef5106db1aec32ec11b85f4de2 (presubmit successful).

6 years, 1 month ago (2014-11-15 01:04:18 UTC) #4

Message was sent while issue was closed.

Already checked in, but:
lgtm