Remove FX_LPCWSTR cast to wchar_t* literals

fpdfsdk/src/javascript/PublicMethods.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/javascript/JavaScript.h"
 #include "../../include/javascript/IJavaScript.h"
 #include "../../include/javascript/JS_Define.h"
 #include "../../include/javascript/JS_Object.h"
@@ skipping 75 matching lines @@
         { "MM",  "%M" },
         //"M"
         { "ss",  "%S" },
         //"s
         { "tt",  "%p" },
         //"t"
 };
 
 static FX_LPCWSTR months[] =
 {
-        (FX_LPCWSTR)L"Jan", (FX_LPCWSTR)L"Feb", (FX_LPCWSTR)L"Mar", (FX_LPCWSTR)L"Apr", (FX_LPCWSTR)L"May", (FX_LPCWSTR)L"Jun", (FX_LPCWSTR)L"Jul", (FX_LPCWSTR)L"Aug", (FX_LPCWSTR)L"Sep", (FX_LPCWSTR)L"Oct", (FX_LPCWSTR)L"Nov", (FX_LPCWSTR)L"Dec"
+        L"Jan", L"Feb", L"Mar", L"Apr", L"May", L"Jun", L"Jul", L"Aug", L"Sep", L"Oct", L"Nov", L"Dec"
 };
 
 static FX_LPCWSTR fullmonths[] = 
 { 
-        (FX_LPCWSTR)L"January", (FX_LPCWSTR)L"February", (FX_LPCWSTR)L"March", (FX_LPCWSTR)L"April", (FX_LPCWSTR)L"May", (FX_LPCWSTR)L"June", (FX_LPCWSTR)L"July", (FX_LPCWSTR)L"August", (FX_LPCWSTR)L"September", (FX_LPCWSTR)L"October", (FX_LPCWSTR)L"November", (FX_LPCWSTR)L"December" 
+        L"January", L"February", L"March", L"April", L"May", L"June", L"July", L"August", L"September", L"October", L"November", L"December" 
 };
 
 FX_BOOL CJS_PublicMethods::IsNumber(FX_LPCWSTR string)
 {
         CFX_WideString sTrim = StrTrim(string);
         FX_LPCWSTR pTrim = sTrim;
         FX_LPCWSTR p = pTrim;
 
 
         FX_BOOL bDot = FALSE;
@@ skipping 74 matching lines @@
         }
 }
 
 FX_BOOL CJS_PublicMethods::isReservedMaskChar(wchar_t ch)
 {
         return ch == L'9' || ch == L'A' || ch == L'O' || ch == L'X';
 }
 
 double CJS_PublicMethods::AF_Simple(FX_LPCWSTR sFuction, double dValue1, double dValue2)
 {
-        if (FXSYS_wcsicmp(sFuction,(FX_LPCWSTR)L"AVG") == 0 || FXSYS_wcsicmp(sFuction,(FX_LPCWSTR)L"SUM") == 0)
+        if (FXSYS_wcsicmp(sFuction,L"AVG") == 0 || FXSYS_wcsicmp(sFuction,L"SUM") == 0)
         {
                 return dValue1 + dValue2;
         }
-        else if (FXSYS_wcsicmp(sFuction, (FX_LPCWSTR)L"PRD") == 0)
+        else if (FXSYS_wcsicmp(sFuction, L"PRD") == 0)
         {
                 return dValue1 * dValue2;
         }
-        else if (FXSYS_wcsicmp(sFuction,(FX_LPCWSTR)L"MIN") == 0)
+        else if (FXSYS_wcsicmp(sFuction,L"MIN") == 0)
         {
                 return FX_MIN(dValue1, dValue2);
         }
-        else if (FXSYS_wcsicmp(sFuction,(FX_LPCWSTR)L"MAX") == 0)
+        else if (FXSYS_wcsicmp(sFuction,L"MAX") == 0)
         {
                 return FX_MAX(dValue1, dValue2);
         }
 
         return dValue1;
 }
 
 CFX_WideString CJS_PublicMethods::StrLTrim(FX_LPCWSTR pStr)
 {
         while (*pStr && *pStr == L' ') pStr++;
@@ skipping 364 matching lines @@
 
                 bWrongFormat = FALSE;
         }
         else
         {
                 bWrongFormat = TRUE;
                 return dt;
         }
 
         CFX_WideString swTemp;
-        swTemp.Format((FX_LPCWSTR)L"%d/%d/%d %d:%d:%d",nMonth,nDay,nYear,nHour,nMin,nSec);
+        swTemp.Format(L"%d/%d/%d %d:%d:%d",nMonth,nDay,nYear,nHour,nMin,nSec);
         return JS_DateParse(swTemp);
 }
 
 double CJS_PublicMethods::MakeRegularDate(const CFX_WideString & value, const CFX_WideString & format, FX_BOOL& bWrongFormat)
 {
         double dt = JS_GetDateTime();
 
         if (format.IsEmpty() || value.IsEmpty())
                 return dt;
 
@@ skipping 325 matching lines @@
                         case 's':
                         case 't':
                                 if (remaining == 0 || format.GetAt(i+1) != c)
                                 {
                                         switch (c)
                                         {
                                                 case 'y':
                                                         sPart += c;
                                                         break;
                                                 case 'm':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nMonth);
+                                                        sPart.Format(L"%d",nMonth);
                                                         break;
                                                 case 'd':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nDay);
+                                                        sPart.Format(L"%d",nDay);
                                                         break;
                                                 case 'H':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nHour);
+                                                        sPart.Format(L"%d",nHour);
                                                         break;
                                                 case 'h':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nHour>12?nHour - 12:nHour);
+                                                        sPart.Format(L"%d",nHour>12?nHour - 12:nHour);
                                                         break;
                                                 case 'M':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nMin);
+                                                        sPart.Format(L"%d",nMin);
                                                         break;
                                                 case 's':
-                                                        sPart.Format((FX_LPCWSTR)L"%d",nSec);
+                                                        sPart.Format(L"%d",nSec);
                                                         break;
                                                 case 't':
                                                         sPart += nHour>12?'p':'a';
                                                         break;
                                         }
                                         i++;
                                 }
                                 else if (remaining == 1 || format.GetAt(i+2) != c)
                                 {
                                         switch (c)
                                         {
                                                 case 'y':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nYear - (nYear / 100) * 100);
+                                                        sPart.Format(L"%02d",nYear - (nYear / 100) * 100);
                                                         break;
                                                 case 'm':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nMonth);
+                                                        sPart.Format(L"%02d",nMonth);
                                                         break;
                                                 case 'd':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nDay);
+                                                        sPart.Format(L"%02d",nDay);
                                                         break;
                                                 case 'H':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nHour);
+                                                        sPart.Format(L"%02d",nHour);
                                                         break;
                                                 case 'h':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nHour>12?nHour - 12:nHour);
+                                                        sPart.Format(L"%02d",nHour>12?nHour - 12:nHour);
                                                         break;
                                                 case 'M':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nMin);
+                                                        sPart.Format(L"%02d",nMin);
                                                         break;
                                                 case 's':
-                                                        sPart.Format((FX_LPCWSTR)L"%02d",nSec);
+                                                        sPart.Format(L"%02d",nSec);
                                                         break;
                                                 case 't':
-                                                        sPart = nHour>12? (FX_LPCWSTR)L"pm": (FX_LPCWSTR)L"am";
+                                                        sPart = nHour>12? L"pm": L"am";
                                                         break;
                                         }
                                         i+=2;
                                 }
                                 else if (remaining == 2 || format.GetAt(i+3) != c)
                                 {
                                         switch (c)
                                         {
                                                 case 'm':
                                                         i+=3;
                                                         if (nMonth > 0&&nMonth <= 12)
                                                                 sPart += months[nMonth - 1];
                                                         break;
                                                 default:
                                                         i+=3;
                                                         sPart += c;
                                                         sPart += c;
                                                         sPart += c;
                                                         break;
                                         }
                                 }
                                 else if (remaining == 3 || format.GetAt(i+4) != c)
                                 {
                                         switch (c)
                                         {
                                                 case 'y':
-                                                        sPart.Format((FX_LPCWSTR)L"%04d",nYear);
+                                                        sPart.Format(L"%04d",nYear);
                                                         i += 4;
                                                         break;
                                                 case 'm':
                                                         i+=4;
                                                         if (nMonth > 0&&nMonth <= 12)
                                                                 sPart += fullmonths[nMonth - 1];
                                                         break;
                                                 default:
                                                         i += 4;
                                                         sPart += c;
@@ skipping 253 matching lines @@
     CFX_WideString w_strValue = val;
 
         if (pEvent->WillCommit())
         {
                 CFX_WideString wstrChange = w_strChange;
                 CFX_WideString wstrValue = StrLTrim(w_strValue);
                 if (wstrValue.IsEmpty())
                         return TRUE;
                 
                 CFX_WideString swTemp = wstrValue;
-                swTemp.Replace((FX_LPCWSTR)L",", (FX_LPCWSTR)L".");
+                swTemp.Replace(L",", L".");
                 if (!IsNumber(swTemp)) //!(IsNumber(wstrChange) && 
                 {
                         pEvent->Rc() = FALSE;
                         sError = JSGetStringFromID(pContext, IDS_STRING_JSAFNUMBER_KEYSTROKE);
                         Alert(pContext, sError);
                         return TRUE;
                 }
                 return TRUE; // it happens after the last keystroke and before validating,
         }
         
@@ skipping 368 matching lines @@
         if (params.size() != 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 ASSERT(pContext != NULL);
 
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         int iIndex = params[0];
-        FX_LPCWSTR cFormats[] =  {(FX_LPCWSTR)L"m/d", (FX_LPCWSTR)L"m/d/yy", (FX_LPCWSTR)L"mm/dd/yy", (FX_LPCWSTR)L"mm/yy", (FX_LPCWSTR)L"d-mmm", (FX_LPCWSTR)L"d-mmm-yy", (FX_LPCWSTR)L"dd-mmm-yy",
-                (FX_LPCWSTR)L"yy-mm-dd", (FX_LPCWSTR)L"mmm-yy", (FX_LPCWSTR)L"mmmm-yy", (FX_LPCWSTR)L"mmm d, yyyy", (FX_LPCWSTR)L"mmmm d, yyyy",
-                (FX_LPCWSTR)L"m/d/yy h:MM tt", (FX_LPCWSTR)L"m/d/yy HH:MM" };
+        FX_LPCWSTR cFormats[] =  {L"m/d", L"m/d/yy", L"mm/dd/yy", L"mm/yy", L"d-mmm", L"d-mmm-yy", L"dd-mmm-yy",
+                L"yy-mm-dd", L"mmm-yy", L"mmmm-yy", L"mmm d, yyyy", L"mmmm d, yyyy",
+                L"m/d/yy h:MM tt", L"m/d/yy HH:MM" };
 
         ASSERT(iIndex < sizeof(cFormats)/sizeof(FX_LPCWSTR));
 
         if (iIndex < 0)
                 iIndex = 0;
         if (iIndex >= sizeof(cFormats)/sizeof(FX_LPCWSTR))
                 iIndex = 0;
         CJS_Parameters newParams;
         CJS_Value val(isolate,cFormats[iIndex]);
         newParams.push_back(val);
         return AFDate_FormatEx(cc,newParams,vRet,sError);
 }
 
 //AFDate_KeystrokeEx(cFormat)
 FX_BOOL CJS_PublicMethods::AFDate_Keystroke(OBJ_METHOD_PARAMS)
 {
         v8::Isolate* isolate = ::GetIsolate(cc);
 
         if (params.size() != 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 ASSERT(pContext != NULL);
 
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         int iIndex = params[0];
-        FX_LPCWSTR cFormats[] =  {(FX_LPCWSTR)L"m/d", (FX_LPCWSTR)L"m/d/yy", (FX_LPCWSTR)L"mm/dd/yy", (FX_LPCWSTR)L"mm/yy", (FX_LPCWSTR)L"d-mmm", (FX_LPCWSTR)L"d-mmm-yy", (FX_LPCWSTR)L"dd-mmm-yy",
-                (FX_LPCWSTR)L"yy-mm-dd", (FX_LPCWSTR)L"mmm-yy", (FX_LPCWSTR)L"mmmm-yy", (FX_LPCWSTR)L"mmm d, yyyy", (FX_LPCWSTR)L"mmmm d, yyyy",
-                (FX_LPCWSTR)L"m/d/yy h:MM tt", (FX_LPCWSTR)L"m/d/yy HH:MM" };
+        FX_LPCWSTR cFormats[] =  {L"m/d", L"m/d/yy", L"mm/dd/yy", L"mm/yy", L"d-mmm", L"d-mmm-yy", L"dd-mmm-yy",
+                L"yy-mm-dd", L"mmm-yy", L"mmmm-yy", L"mmm d, yyyy", L"mmmm d, yyyy",
+                L"m/d/yy h:MM tt", L"m/d/yy HH:MM" };
 
         ASSERT(iIndex<sizeof(cFormats)/sizeof(FX_LPCWSTR));
 
         if (iIndex < 0)
                 iIndex = 0;
         if (iIndex >= sizeof(cFormats)/sizeof(FX_LPCWSTR))
                 iIndex = 0;
         CJS_Parameters newParams;
         CJS_Value val(isolate,cFormats[iIndex]);
         newParams.push_back(val);
         return AFDate_KeystrokeEx(cc,newParams,vRet,sError);
 }
 
 //function AFTime_Format(ptf)
 FX_BOOL CJS_PublicMethods::AFTime_Format(OBJ_METHOD_PARAMS)
 {
         v8::Isolate* isolate = ::GetIsolate(cc);
 
         if (params.size() != 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 ASSERT(pContext != NULL);
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         int iIndex = params[0];
-        FX_LPCWSTR cFormats[] = {(FX_LPCWSTR)L"HH:MM", (FX_LPCWSTR)L"h:MM tt", (FX_LPCWSTR)L"HH:MM:ss", (FX_LPCWSTR)L"h:MM:ss tt"};
+        FX_LPCWSTR cFormats[] = {L"HH:MM", L"h:MM tt", L"HH:MM:ss", L"h:MM:ss tt"};
 
         ASSERT(iIndex<sizeof(cFormats)/sizeof(FX_LPCWSTR));
 
         if (iIndex < 0)
                 iIndex = 0;
         if (iIndex >= sizeof(cFormats)/sizeof(FX_LPCWSTR))
                 iIndex = 0;
         CJS_Parameters newParams;
         CJS_Value val(isolate,cFormats[iIndex]);
         newParams.push_back(val);
         return AFDate_FormatEx(cc,newParams,vRet,sError);
 }
 
 FX_BOOL CJS_PublicMethods::AFTime_Keystroke(OBJ_METHOD_PARAMS)
 {
         v8::Isolate* isolate = ::GetIsolate(cc);
         if (params.size() != 1)
         {
                 CJS_Context* pContext = (CJS_Context*)cc;
                 ASSERT(pContext != NULL);
                 sError = JSGetStringFromID(pContext, IDS_STRING_JSPARAMERROR);
                 return FALSE;
         }
 
         int iIndex = params[0];
-        FX_LPCWSTR cFormats[] = {(FX_LPCWSTR)L"HH:MM", (FX_LPCWSTR)L"h:MM tt", (FX_LPCWSTR)L"HH:MM:ss", (FX_LPCWSTR)L"h:MM:ss tt"};
+        FX_LPCWSTR cFormats[] = {L"HH:MM", L"h:MM tt", L"HH:MM:ss", L"h:MM:ss tt"};
 
         ASSERT(iIndex<sizeof(cFormats)/sizeof(FX_LPCWSTR));
 
         if (iIndex < 0)
                 iIndex = 0;
         if (iIndex >= sizeof(cFormats)/sizeof(FX_LPCWSTR))
                 iIndex = 0;
         CJS_Parameters newParams;
         CJS_Value val(isolate,cFormats[iIndex]);
         newParams.push_back(val);
@@ skipping 540 matching lines @@
                 nums.SetElement(nIndex,CJS_Value(isolate,(FX_LPCWSTR)sPart));   
         }
 
         if (nums.GetLength() > 0)
                 vRet = nums;
         else
                 vRet.SetNull();
 
         return TRUE;
 }