Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 725903002: Timeline: move preview up, pie chart down in Details (Closed)

Created:
6 years, 1 month ago by caseq
Modified:
6 years, 1 month ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, paulirish1
Project:
blink
Visibility:
Public.

Description

Timeline: move preview up, pie chart down in Details This moved Preview image for Paint & Images up (just after base timing info) and Pie Chart down (just before stacks, but after all event-specific info) in Timeline Details view. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
Paul asked for this. Screenshot: https://drive.google.com/open?id=0B_yi9xtujhXSV3FiQTdNNkFKWmc
6 years, 1 month ago (2014-11-14 10:31:43 UTC) #2
caseq
Wrong link :( Here's correct one: https://drive.google.com/file/d/0B_yi9xtujhXScktQOUJ4azNmZ1E/view?usp=sharing
6 years, 1 month ago (2014-11-14 10:33:19 UTC) #3
pfeldman
lgtm
6 years, 1 month ago (2014-11-17 14:11:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725903002/1
6 years, 1 month ago (2014-11-17 14:26:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 15:46:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185447

Powered by Google App Engine
This is Rietveld 408576698