Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 725903002: Timeline: move preview up, pie chart down in Details (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 267e0659922629f176cdf499e7b04e93abdcb45e..eeb30b8df6505cd7ca48c14809325c3ecca02529 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -508,7 +508,9 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
contentHelper.appendTextRow(WebInspector.UIString("Type"), WebInspector.TimelineUIUtils.eventTitle(event, model));
contentHelper.appendTextRow(WebInspector.UIString("Self Time"), Number.millisToString(event.selfTime, true));
contentHelper.appendTextRow(WebInspector.UIString("Start Time"), Number.millisToString((event.startTime - model.minimumRecordTime())));
- contentHelper.appendElementRow(WebInspector.UIString("Aggregated Time"), pieChart);
+ if (event.previewElement)
+ contentHelper.appendElementRow(WebInspector.UIString("Preview"), event.previewElement);
+
var eventData = event.args["data"];
var initiator = event.initiator;
@@ -629,8 +631,8 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
div.textContent = warning;
contentHelper.appendElementRow(WebInspector.UIString("Warning"), div);
}
- if (event.previewElement)
- contentHelper.appendElementRow(WebInspector.UIString("Preview"), event.previewElement);
+
+ contentHelper.appendElementRow(WebInspector.UIString("Aggregated Time"), pieChart);
if (event.stackTrace || (event.initiator && event.initiator.stackTrace) || event.invalidationTrackingEvents)
WebInspector.TimelineUIUtils._generateCauses(event, model.target(), contentHelper);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698