Update TextTrackCue tests to use VTTCue where appropriate

Update TextTrackCue tests to use VTTCue where appropriate

The Opera tests were fixed upstream and re-imported:
https://github.com/w3c/web-platform-tests/commit/8c08468d5494c9026c2a857f366c631651c413fd
https://github.com/w3c/web-platform-tests/commit/da34397c2c16170da60e5c7638e00c0edadcf0be

A new test in cues.html requres a more recent testharness.js
than we have and was disabled.

BUG=270340
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162026

[philipj_slow, 2013-11-14 08:52:49]

Part 1: https://codereview.chromium.org/63173020/
Part 2: this review

[jochen (gone - plz use gerrit), 2013-11-14 12:02:00]

can't you take out the custom constructor hack at this point?

[philipj_slow, 2013-11-14 12:09:05]

On 2013/11/14 12:02:00, jochen wrote:
> can't you take out the custom constructor hack at this point?

I'd love to, but apparently the consensus (in private email between Glenn Adams
and Aaron Colwell I think) was to keep it around until it was deemed safe to
remove, since there may be site compat issues. That's why the UseCounter is
there.

[jochen (gone - plz use gerrit), 2013-11-14 12:19:44]

mhm

lgtm I guess

would be great if you guys could have such discussions on crbug or somewhere in
the future :)

[philipj_slow, 2013-11-14 13:04:12]

On 2013/11/14 12:19:44, jochen wrote:
> mhm
> 
> lgtm I guess
> 
> would be great if you guys could have such discussions on crbug or somewhere
in
> the future :)

To be fair it's possible that I did, but I only heard about it second-hand. In
any case I reluctantly agree, since breaking the Web isn't part of the job
description.

[philipj_slow, 2013-11-14 13:04:38]

On 2013/11/14 13:04:12, philipj wrote:
> On 2013/11/14 12:19:44, jochen wrote:
> > mhm
> > 
> > lgtm I guess
> > 
> > would be great if you guys could have such discussions on crbug or somewhere
> in
> > the future :)
> 
> To be fair it's possible that I did, but I only heard about it second-hand. In
> any case I reluctantly agree, since breaking the Web isn't part of the job
> description.

... possible that *they* did ...

[commit-bot: I haz the power, 2013-11-14 13:06:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/72543003/1

[commit-bot: I haz the power, 2013-11-14 14:44:51]

Change committed as 162026

[acolwell GONE FROM CHROMIUM, 2013-11-14 17:38:44]

On 2013/11/14 12:19:44, jochen wrote:
> mhm
> 
> lgtm I guess
> 
> would be great if you guys could have such discussions on crbug or somewhere
in
> the future :)

There was no intent to be secretive about this. I believe Glenn & I just
discussed this in person at BlinkOn. This is a web facing change so we just
assumed that the constructor removal would go through the normal "Intent to
Remove" process.

[gasubic, 2013-11-14 21:40:23]

On Fri, Nov 15, 2013 at 1:38 AM, <acolwell@chromium.org> wrote:

> On 2013/11/14 12:19:44, jochen wrote:
>
>> mhm
>>
>
>  lgtm I guess
>>
>
>  would be great if you guys could have such discussions on crbug or
>> somewhere
>>
> in
>
>> the future :)
>>
>
> There was no intent to be secretive about this. I believe Glenn & I just
> discussed this in person at BlinkOn. This is a web facing change so we just
> assumed that the constructor removal would go through the normal "Intent to
> Remove" process.
>

exactly


>
> https://codereview.chromium.org/72543003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.