Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: LayoutTests/media/track/opera/interfaces/TextTrack/cues.html

Issue 72543003: Update TextTrackCue tests to use VTTCue where appropriate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
diff --git a/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html b/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
index 447d196d46c3856ec46379934b6a1da56860fb39..c89316a28da21481c3362daac1ac6fdd33866ca2 100644
--- a/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
+++ b/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html
@@ -9,29 +9,23 @@ setup(function(){
window.t1 = video.addTextTrack('subtitles');
window.track = document.createElement('track');
track['default'] = true;
- video.appendChild(track);
+ video.appendChild(track); // queues a task to "honor user preferences...", media element event task source
window.t2 = track.track;
window.t1_cues = t1.cues
window.t2_cues = t2.cues
});
-// Skipping this test due to https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066,
-// tracking uncommenting this when test is fixed with webkit.org/b/104255
-// test(function(){
-// assert_equals(t1.cues, t1_cues, 't1.cues should return same object');
-// assert_equals(t2.cues, t2_cues, 't2.cues should return same object');
-// assert_not_equals(t1.cues, t2.cues, 't1.cues and t2.cues should be different objects');
-// assert_not_equals(t1.cues, null, 't1.cues should not be null');
-// assert_not_equals(t2.cues, null, 't2.cues should not be null');
-// assert_equals(t1.cues.length, 0, 't1.cues should have length 0');
-// assert_equals(t2.cues.length, 0, 't2.cues should have length 0');
-// }, document.title+', empty list');
test(function(){
- var c = new TextTrackCue(0, 1, "text");
+ assert_equals(t1.cues, t1_cues, 't1.cues should return same object');
+ assert_not_equals(t1.cues, null, 't1.cues should not be null');
+ assert_equals(t1.cues.length, 0, 't1.cues should have length 0');
+}, document.title+', empty list');
+test(function(){
+ var c = new VTTCue(0, 1, "text");
c.id = "id";
t1.addCue(c);
assert_equals(t1.cues, t1_cues, "t1.cues should return same object");
assert_equals(t1.cues.length, 1, "t1.cues.length");
- var c2 = new TextTrackCue(1, 2, "text2");
+ var c2 = new VTTCue(1, 2, "text2");
c2.id = "id2";
t1.addCue(c2);
assert_equals(t1.cues, t1_cues, "t1.cues should return the same object after adding a second cue");
@@ -68,4 +62,17 @@ test(function(){
assert_equals(t1.cues[0].id, 'id');
assert_equals(t1.cues[1].id, 'id2');
}, document.title+', changing order');
+// FIXME: disabled because it requires a newer testharness.js
+//async_test(function(){
+// t1.mode = 'showing';
+// assert_equals(t2.cues, null, 't2.cues should be null');
+// video.onplay = this.step_func(function(){
+// assert_equals(t2.cues, t2_cues, 't2.cues should return same object');
+// assert_not_equals(t1.cues, t2.cues, 't1.cues and t2.cues should be different objects');
+// assert_not_equals(t2.cues, null, 't2.cues should not be null');
+// assert_equals(t2.cues.length, 0, 't2.cues should have length 0');
+// this.done();
+// });
+// video.play(); // queues a task to fire 'play', media element event task source
+//}, document.title+', default attribute');
</script>

Powered by Google App Engine
This is Rietveld 408576698