Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Unified Diff: chrome/service/service_utility_process_host.h

Issue 725353003: Don't pass ProcessHandle through ChildProcessHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process/process_win.cc ('k') | chrome/service/service_utility_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_utility_process_host.h
diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h
index 6b320aa9ec3f65d193ed70c089c911e54824a1c2..db9d88489892e96fa2decfc3469fb043d5a01d4a 100644
--- a/chrome/service/service_utility_process_host.h
+++ b/chrome/service/service_utility_process_host.h
@@ -115,7 +115,7 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
// ChildProcessHostDelegate implementation:
virtual void OnChildDisconnected() override;
virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual base::ProcessHandle GetHandle() const override;
+ virtual const base::Process& GetProcess() const override;
private:
// Starts a process. Returns true iff it succeeded.
@@ -124,7 +124,7 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
// Launch the child process synchronously.
bool Launch(base::CommandLine* cmd_line, bool no_sandbox);
- base::ProcessHandle handle() const { return handle_; }
+ base::ProcessHandle handle() const { return process_.Handle(); }
void OnMetafileSpooled(bool success);
void OnPDFToEmfFinished(bool success);
@@ -143,7 +143,7 @@ class ServiceUtilityProcessHost : public content::ChildProcessHostDelegate {
const std::string& printer_name);
scoped_ptr<content::ChildProcessHost> child_process_host_;
- base::ProcessHandle handle_;
+ base::Process process_;
// A pointer to our client interface, who will be informed of progress.
scoped_refptr<Client> client_;
scoped_refptr<base::MessageLoopProxy> client_message_loop_proxy_;
« no previous file with comments | « base/process/process_win.cc ('k') | chrome/service/service_utility_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698