Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/service/service_utility_process_host.h

Issue 725353003: Don't pass ProcessHandle through ChildProcessHostDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/process/process_win.cc ('k') | chrome/service/service_utility_process_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_ 5 #ifndef CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_
6 #define CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_ 6 #define CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 protected: 109 protected:
110 bool Send(IPC::Message* msg); 110 bool Send(IPC::Message* msg);
111 111
112 // Allows this method to be overridden for tests. 112 // Allows this method to be overridden for tests.
113 virtual base::FilePath GetUtilityProcessCmd(); 113 virtual base::FilePath GetUtilityProcessCmd();
114 114
115 // ChildProcessHostDelegate implementation: 115 // ChildProcessHostDelegate implementation:
116 virtual void OnChildDisconnected() override; 116 virtual void OnChildDisconnected() override;
117 virtual bool OnMessageReceived(const IPC::Message& message) override; 117 virtual bool OnMessageReceived(const IPC::Message& message) override;
118 virtual base::ProcessHandle GetHandle() const override; 118 virtual const base::Process& GetProcess() const override;
119 119
120 private: 120 private:
121 // Starts a process. Returns true iff it succeeded. 121 // Starts a process. Returns true iff it succeeded.
122 bool StartProcess(bool no_sandbox); 122 bool StartProcess(bool no_sandbox);
123 123
124 // Launch the child process synchronously. 124 // Launch the child process synchronously.
125 bool Launch(base::CommandLine* cmd_line, bool no_sandbox); 125 bool Launch(base::CommandLine* cmd_line, bool no_sandbox);
126 126
127 base::ProcessHandle handle() const { return handle_; } 127 base::ProcessHandle handle() const { return process_.Handle(); }
128 128
129 void OnMetafileSpooled(bool success); 129 void OnMetafileSpooled(bool success);
130 void OnPDFToEmfFinished(bool success); 130 void OnPDFToEmfFinished(bool success);
131 131
132 // Messages handlers: 132 // Messages handlers:
133 void OnRenderPDFPagesToMetafilesPageCount(int page_count); 133 void OnRenderPDFPagesToMetafilesPageCount(int page_count);
134 void OnRenderPDFPagesToMetafilesPageDone(bool success, float scale_factor); 134 void OnRenderPDFPagesToMetafilesPageDone(bool success, float scale_factor);
135 void OnGetPrinterCapsAndDefaultsSucceeded( 135 void OnGetPrinterCapsAndDefaultsSucceeded(
136 const std::string& printer_name, 136 const std::string& printer_name,
137 const printing::PrinterCapsAndDefaults& caps_and_defaults); 137 const printing::PrinterCapsAndDefaults& caps_and_defaults);
138 void OnGetPrinterCapsAndDefaultsFailed(const std::string& printer_name); 138 void OnGetPrinterCapsAndDefaultsFailed(const std::string& printer_name);
139 void OnGetPrinterSemanticCapsAndDefaultsSucceeded( 139 void OnGetPrinterSemanticCapsAndDefaultsSucceeded(
140 const std::string& printer_name, 140 const std::string& printer_name,
141 const printing::PrinterSemanticCapsAndDefaults& caps_and_defaults); 141 const printing::PrinterSemanticCapsAndDefaults& caps_and_defaults);
142 void OnGetPrinterSemanticCapsAndDefaultsFailed( 142 void OnGetPrinterSemanticCapsAndDefaultsFailed(
143 const std::string& printer_name); 143 const std::string& printer_name);
144 144
145 scoped_ptr<content::ChildProcessHost> child_process_host_; 145 scoped_ptr<content::ChildProcessHost> child_process_host_;
146 base::ProcessHandle handle_; 146 base::Process process_;
147 // A pointer to our client interface, who will be informed of progress. 147 // A pointer to our client interface, who will be informed of progress.
148 scoped_refptr<Client> client_; 148 scoped_refptr<Client> client_;
149 scoped_refptr<base::MessageLoopProxy> client_message_loop_proxy_; 149 scoped_refptr<base::MessageLoopProxy> client_message_loop_proxy_;
150 bool waiting_for_reply_; 150 bool waiting_for_reply_;
151 151
152 // Start time of operation. 152 // Start time of operation.
153 base::Time start_time_; 153 base::Time start_time_;
154 154
155 class PdfToEmfState; 155 class PdfToEmfState;
156 scoped_ptr<PdfToEmfState> pdf_to_emf_state_; 156 scoped_ptr<PdfToEmfState> pdf_to_emf_state_;
157 157
158 base::WeakPtrFactory<ServiceUtilityProcessHost> weak_ptr_factory_; 158 base::WeakPtrFactory<ServiceUtilityProcessHost> weak_ptr_factory_;
159 159
160 DISALLOW_COPY_AND_ASSIGN(ServiceUtilityProcessHost); 160 DISALLOW_COPY_AND_ASSIGN(ServiceUtilityProcessHost);
161 }; 161 };
162 162
163 #endif // CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_ 163 #endif // CHROME_SERVICE_SERVICE_UTILITY_PROCESS_HOST_H_
OLDNEW
« no previous file with comments | « base/process/process_win.cc ('k') | chrome/service/service_utility_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698