Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 725293003: don't use to-be-deprecated Value::To* without isolate parameter (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

don't use to-be-deprecated Value::To* without isolate parameter R=svenpanne@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -134 lines) Patch
M test/cctest/compiler/test-run-inlining.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 37 chunks +100 lines, -91 lines 0 comments Download
M test/cctest/test-debug.cc View 8 chunks +11 lines, -9 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M test/cctest/test-strings.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dcarney
ptal
6 years ago (2014-11-24 09:05:53 UTC) #2
Sven Panne
lgtm
6 years ago (2014-11-24 10:02:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725293003/40001
6 years ago (2014-11-24 10:03:13 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-24 10:30:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698