test/cctest/test-log.cc - Issue 725293003: don't use to-be-deprecated Value::To* without isolate parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-log.cc

Issue 725293003: don't use to-be-deprecated Value::To* without isolate parameter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-log.cc

diff --git a/test/cctest/test-log.cc b/test/cctest/test-log.cc

index 482f89f9c47675c4a70c1183260081cf07c26a92..5ea283f96a091d75eef618b334182a111c973cad 100644

--- a/test/cctest/test-log.cc

+++ b/test/cctest/test-log.cc

@@ -496,7 +496,7 @@ TEST(EquivalenceOfLoggingAndTraversal) {

}

// The result either be a "true" literal or problem description.

if (!result->IsTrue()) {

- v8::Local<v8::String> s = result->ToString();

+ v8::Local<v8::String> s = result->ToString(isolate);

i::ScopedVector<char> data(s->Utf8Length() + 1);

CHECK_NE(NULL, data.start());

s->WriteUtf8(data.start());

« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »