content/renderer/render_view_impl.cc - Issue 725243002: add flag to disable link disambiguation popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 725243002: add flag to disable link disambiguation popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add histogram.xml entry for flag Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 7f38d6c98c43cf5910a9efe523420224fe8b32d7..ed8b491410f443e2e56d58ded84a3b1658ae2210 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -4051,6 +4051,9 @@ bool RenderViewImpl::didTapMultipleTargets(

const WebSize& inner_viewport_offset,

const WebRect& touch_rect,

const WebVector<WebRect>& target_rects) {

+ if (!switches::IsLinkDisambiguationPopupEnabled())

jdduke (slow) 2014/11/23 20:01:00 Could we either cache this switch or push it to Bl

+ return false;

// Never show a disambiguation popup when accessibility is enabled,

// as this interferes with "touch exploration".

AccessibilityMode accessibility_mode =