chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc - Issue 725243002: add flag to disable link disambiguation popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

Issue 725243002: add flag to disable link disambiguation popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add histogram.xml entry for flag Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

index 8c2dce3786b12b205a47fd6c6c22d456baee7f28..cf5a5d3f79c2a07e26ca9859f6aa4c49053a5536 100644

--- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

+++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc

@@ -161,9 +161,6 @@ void ChromeWebContentsViewDelegateViews::ShowDisambiguationPopup(

const base::Callback<void(ui::GestureEvent*)>& gesture_cb,

const base::Callback<void(ui::MouseEvent*)>& mouse_cb) {

#if defined(USE_AURA)

- if (!browser_defaults::kShowLinkDisambiguationPopup)

- return;

link_disambiguation_popup_.reset(new LinkDisambiguationPopup);

link_disambiguation_popup_->Show(

views::Widget::GetTopLevelWidgetForNativeView(GetActiveNativeView()),

« no previous file with comments | « chrome/browser/renderer_preferences_util.cc ('k') | content/renderer/render_view_impl.cc » ('j') | content/renderer/render_view_impl.cc » ('J')