Move serving_dirs to UserStorySet, update user_story_runner.

Move serving_dirs to UserStorySet, delete Page.archive_path (instead using PageSet.WprFilePathForUserStory).
Update user_story_runner to no longer gate archive-specific logic with instanceof PageSet check.

BUG=439512
Committed: https://crrev.com/ff5b3a36bc56b38fbb9797e1e16b1ef369271097
Cr-Commit-Position: refs/heads/master@{#308134}

[chrishenry, 2014-12-06 05:39:37]

Patchset #1 (id:1) has been deleted

[chrishenry, 2014-12-06 05:56:45]

Patchset #1 (id:20001) has been deleted

[chrishenry, 2014-12-06 06:47:02]

chrishenry@google.com changed reviewers:
+ nednguyen@google.com, slamm@chromium.org

[nednguyen, 2014-12-08 00:45:44]

On 2014/12/06 06:47:02, chrishenry wrote:

Thanks! 
One of the exit criteria  of the whole page_runner overhaul bug have is we no
longer see the word "page" in user_story_runner + user_story_runner_unittest ;)

[nednguyen, 2014-12-08 00:45:55]

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner.py:277: def
_CheckArchives(user_story_set):
why change the parameter? Passing in archive_data_file, wpr_archive_info,
user_stories is clearer to me.

Also, you need user_stories since not all user stories belong to user_story_set
will be run due to the --page-filter logic above.

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner_unittest.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner_unittest.py:356: ps =
page_set.PageSet()
This test now can modified to test user_story_set instead of page_set.

[nednguyen, 2014-12-08 19:01:58]

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/__init__.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/__init__.py:88: return False
why not make a is_local field that can be set by the constructor?

[chrishenry, 2014-12-08 19:02:41]

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner.py:277: def
_CheckArchives(user_story_set):
On 2014/12/08 00:45:55, nednguyen wrote:
> why change the parameter? Passing in archive_data_file, wpr_archive_info,
> user_stories is clearer to me.
> 
> Also, you need user_stories since not all user stories belong to
user_story_set
> will be run due to the --page-filter logic above.

I originally needed user_story_set, but switched the logic so that it doesn't
now, so reverted the signature.

The original code pass all of the pages. I switched it to pass
filtered_user_stories.

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_runner_unittest.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_runner_unittest.py:356: ps =
page_set.PageSet()
On 2014/12/08 00:45:55, nednguyen wrote:
> This test now can modified to test user_story_set instead of page_set.

Done.

[nednguyen, 2014-12-09 03:10:07]

On 2014/12/08 19:02:41, chrishenry wrote:
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/user_story/user_story_runner.py (right):
> 
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/user_story/user_story_runner.py:277: def
> _CheckArchives(user_story_set):
> On 2014/12/08 00:45:55, nednguyen wrote:
> > why change the parameter? Passing in archive_data_file, wpr_archive_info,
> > user_stories is clearer to me.
> > 
> > Also, you need user_stories since not all user stories belong to
> user_story_set
> > will be run due to the --page-filter logic above.
> 
> I originally needed user_story_set, but switched the logic so that it doesn't
> now, so reverted the signature.
> 
> The original code pass all of the pages. I switched it to pass
> filtered_user_stories.
> 
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
(right):
> 
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/user_story/user_story_runner_unittest.py:356: ps =
> page_set.PageSet()
> On 2014/12/08 00:45:55, nednguyen wrote:
> > This test now can modified to test user_story_set instead of page_set.
> 
> Done.

Rebase?

[chrishenry, 2014-12-09 19:16:12]

On 2014/12/09 03:10:07, nednguyen wrote:
> On 2014/12/08 19:02:41, chrishenry wrote:
> >
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> > File tools/telemetry/telemetry/user_story/user_story_runner.py (right):
> > 
> >
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> > tools/telemetry/telemetry/user_story/user_story_runner.py:277: def
> > _CheckArchives(user_story_set):
> > On 2014/12/08 00:45:55, nednguyen wrote:
> > > why change the parameter? Passing in archive_data_file, wpr_archive_info,
> > > user_stories is clearer to me.
> > > 
> > > Also, you need user_stories since not all user stories belong to
> > user_story_set
> > > will be run due to the --page-filter logic above.
> > 
> > I originally needed user_story_set, but switched the logic so that it
doesn't
> > now, so reverted the signature.
> > 
> > The original code pass all of the pages. I switched it to pass
> > filtered_user_stories.
> > 
> >
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> > File tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
> (right):
> > 
> >
>
https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
> > tools/telemetry/telemetry/user_story/user_story_runner_unittest.py:356: ps =
> > page_set.PageSet()
> > On 2014/12/08 00:45:55, nednguyen wrote:
> > > This test now can modified to test user_story_set instead of page_set.
> > 
> > Done.
> 
> Rebase?

Done.

[nednguyen, 2014-12-09 20:19:12]

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/__init__.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/__init__.py:88: return False
On 2014/12/08 19:01:58, nednguyen wrote:
> why not make a is_local field that can be set by the constructor?

Ping.

[chrishenry, 2014-12-12 00:44:40]

Address review comment.

[chrishenry, 2014-12-12 00:45:31]

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/__init__.py (right):

https://codereview.chromium.org/725133005/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/__init__.py:88: return False
On 2014/12/09 20:19:12, nednguyen wrote:
> On 2014/12/08 19:01:58, nednguyen wrote:
> > why not make a is_local field that can be set by the constructor?
> 
> Ping.

Done.

[nednguyen, 2014-12-12 17:12:10]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-12-12 17:12:11]

lgtm

[commit-bot: I haz the power, 2014-12-12 17:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/725133005/100001

[commit-bot: I haz the power, 2014-12-12 18:56:59]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2014-12-12 18:58:57]

Patchset 4 (id:??) landed as
https://crrev.com/ff5b3a36bc56b38fbb9797e1e16b1ef369271097
Cr-Commit-Position: refs/heads/master@{#308134}