Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: tools/telemetry/telemetry/user_story/__init__.py

Issue 725133005: Move serving_dirs to UserStorySet, update user_story_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comment. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/user_story/__init__.py
diff --git a/tools/telemetry/telemetry/user_story/__init__.py b/tools/telemetry/telemetry/user_story/__init__.py
index 3b6620ed98487b39e627d2d0315e2040b352aba8..68d9b565ffb243aa55f99b2dd3fd3d26c737d3bb 100644
--- a/tools/telemetry/telemetry/user_story/__init__.py
+++ b/tools/telemetry/telemetry/user_story/__init__.py
@@ -18,14 +18,16 @@ class UserStory(object):
Args:
shared_user_story_state_class: subclass of
- telemetry.user_story.shared_user_story_state.SharedUserStoryState.
+ telemetry.user_story.shared_user_story_state.SharedUserStoryState.
name: string name of this user story that can be used for identifying user
- story in results output.
+ story in results output.
labels: A list or set of string labels that are used for filtering. See
- user_story.user_story_filter for more information.
+ user_story.user_story_filter for more information.
+ is_local: If true, the user story does not require network.
"""
- def __init__(self, shared_user_story_state_class, name='', labels=None):
+ def __init__(self, shared_user_story_state_class, name='', labels=None,
+ is_local=False):
assert issubclass(shared_user_story_state_class,
shared_user_story_state.SharedUserStoryState)
self._shared_user_story_state_class = shared_user_story_state_class
@@ -40,6 +42,7 @@ class UserStory(object):
else:
assert isinstance(labels, set)
self._labels = labels
+ self._is_local = is_local
@property
def labels(self):
@@ -78,3 +81,8 @@ class UserStory(object):
return self.name
else:
return self.__class__.__name__
+
+ @property
+ def is_local(self):
+ """Returns True iff this user story does not require network."""
+ return self._is_local
« no previous file with comments | « tools/telemetry/telemetry/page/shared_page_state.py ('k') | tools/telemetry/telemetry/user_story/android/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698