Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 72503002: Remove some pass-thrus on RootWindow API in favor of exposing the RootWindowHost again. (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, yusukes+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, sadrul, miu+watch_chromium.org, joi+watch-content_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, penghuang+watch_chromium.org, kalyank, piman+watch_chromium.org, ben+views_chromium.org, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, ben+ash_chromium.org, danakj+watch_chromium.org, James Su, ben+corewm_chromium.org
Visibility:
Public.

Description

Remove some pass-thrus on RootWindow API in favor of exposing the RootWindowHost again. R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235293

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : , #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -407 lines) Patch
M apps/shell/app_shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M ash/display/display_controller.cc View 1 6 chunks +8 lines, -7 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 4 5 6 7 3 chunks +19 lines, -18 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/screen_position_controller.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 2 chunks +16 lines, -12 lines 0 comments Download
M ash/display/virtual_keyboard_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/aura/active_desktop_monitor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/aura/tabs/dock_info_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/dock_info_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 15 chunks +17 lines, -16 lines 0 comments Download
M content/shell/browser/shell_aura.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_root_window_host_win.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/aura/remote_root_window_host_win.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ui/aura/root_window.h View 9 chunks +7 lines, -40 lines 0 comments Download
M ui/aura/root_window.cc View 13 chunks +8 lines, -68 lines 0 comments Download
M ui/aura/root_window_host_ozone.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +0 lines, -3 lines 0 comments Download
M ui/aura/root_window_host_ozone.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +2 lines, -9 lines 0 comments Download
M ui/aura/root_window_host_win.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +0 lines, -4 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +1 line, -10 lines 0 comments Download
M ui/aura/root_window_host_x11.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +0 lines, -4 lines 0 comments Download
M ui/aura/root_window_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +2 lines, -18 lines 0 comments Download
M ui/aura/root_window_host_x11_unittest.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -3 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurawin.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 1 6 chunks +8 lines, -8 lines 0 comments Download
M ui/aura/window.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.h View 1 6 chunks +25 lines, -8 lines 0 comments Download
M ui/aura/window_tree_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 3 4 5 6 7 8 9 5 chunks +6 lines, -6 lines 0 comments Download
M ui/shell/minimal_shell.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/input_method_event_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 6 7 8 9 10 13 chunks +18 lines, -28 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 15 chunks +20 lines, -36 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_util_aurawin.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
Interesting changes are in RootWindowHost (window_tree_host.h/cc) and RootWindow.
7 years, 1 month ago (2013-11-14 23:20:06 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-14 23:29:58 UTC) #2
Ben Goodger (Google)
7 years, 1 month ago (2013-11-15 05:58:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #12 manually as r235293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698