Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: ash/display/display_manager_unittest.cc

Issue 72503002: Remove some pass-thrus on RootWindow API in favor of exposing the RootWindowHost again. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/display/display_controller_unittest.cc ('k') | ash/display/mirror_window_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/display/display_manager.h" 5 #include "ash/display/display_manager.h"
6 6
7 #include "ash/display/display_controller.h" 7 #include "ash/display/display_controller.h"
8 #include "ash/display/display_layout_store.h" 8 #include "ash/display/display_layout_store.h"
9 #include "ash/screen_ash.h" 9 #include "ash/screen_ash.h"
10 #include "ash/shell.h" 10 #include "ash/shell.h"
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
584 584
585 // Connect another display which will become primary. 585 // Connect another display which will become primary.
586 const DisplayInfo external_display_info = 586 const DisplayInfo external_display_info =
587 CreateDisplayInfo(10, gfx::Rect(1, 1, 100, 100)); 587 CreateDisplayInfo(10, gfx::Rect(1, 1, 100, 100));
588 display_info_list.push_back(external_display_info); 588 display_info_list.push_back(external_display_info);
589 display_manager()->OnNativeDisplaysChanged(display_info_list); 589 display_manager()->OnNativeDisplaysChanged(display_info_list);
590 EXPECT_EQ(1U, display_manager()->GetNumDisplays()); 590 EXPECT_EQ(1U, display_manager()->GetNumDisplays());
591 EXPECT_EQ("1,1 100x100", 591 EXPECT_EQ("1,1 100x100",
592 GetDisplayInfoForId(10).bounds_in_native().ToString()); 592 GetDisplayInfoForId(10).bounds_in_native().ToString());
593 EXPECT_EQ("100x100", ash::Shell::GetPrimaryRootWindow()->GetDispatcher()-> 593 EXPECT_EQ("100x100", ash::Shell::GetPrimaryRootWindow()->GetDispatcher()->
594 GetHostSize().ToString()); 594 host()->GetBounds().size().ToString());
595 } 595 }
596 596
597 #if defined(OS_WIN) 597 #if defined(OS_WIN)
598 // Tests that rely on the actual host size/location does not work on windows. 598 // Tests that rely on the actual host size/location does not work on windows.
599 #define MAYBE_EnsurePointerInDisplays DISABLED_EnsurePointerInDisplays 599 #define MAYBE_EnsurePointerInDisplays DISABLED_EnsurePointerInDisplays
600 #define MAYBE_EnsurePointerInDisplays_2ndOnLeft DISABLED_EnsurePointerInDisplays _2ndOnLeft 600 #define MAYBE_EnsurePointerInDisplays_2ndOnLeft DISABLED_EnsurePointerInDisplays _2ndOnLeft
601 #else 601 #else
602 #define MAYBE_EnsurePointerInDisplays EnsurePointerInDisplays 602 #define MAYBE_EnsurePointerInDisplays EnsurePointerInDisplays
603 #define MAYBE_EnsurePointerInDisplays_2ndOnLeft EnsurePointerInDisplays_2ndOnLef t 603 #define MAYBE_EnsurePointerInDisplays_2ndOnLeft EnsurePointerInDisplays_2ndOnLef t
604 #endif 604 #endif
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
972 TestDisplayObserver display_observer; 972 TestDisplayObserver display_observer;
973 Shell::GetScreen()->AddObserver(&display_observer); 973 Shell::GetScreen()->AddObserver(&display_observer);
974 974
975 DisplayManager* display_manager = Shell::GetInstance()->display_manager(); 975 DisplayManager* display_manager = Shell::GetInstance()->display_manager();
976 display_manager->SetSecondDisplayMode(DisplayManager::MIRRORING); 976 display_manager->SetSecondDisplayMode(DisplayManager::MIRRORING);
977 display_manager->UpdateDisplays(); 977 display_manager->UpdateDisplays();
978 EXPECT_TRUE(display_observer.changed_and_reset()); 978 EXPECT_TRUE(display_observer.changed_and_reset());
979 EXPECT_EQ(1U, display_manager->GetNumDisplays()); 979 EXPECT_EQ(1U, display_manager->GetNumDisplays());
980 EXPECT_EQ("0,0 300x400", 980 EXPECT_EQ("0,0 300x400",
981 Shell::GetScreen()->GetPrimaryDisplay().bounds().ToString()); 981 Shell::GetScreen()->GetPrimaryDisplay().bounds().ToString());
982 EXPECT_EQ("400x500", test_api.GetRootWindow()->GetHostSize().ToString()); 982 EXPECT_EQ("400x500",
983 test_api.GetRootWindow()->host()->GetBounds().size().ToString());
983 EXPECT_EQ("300x400", 984 EXPECT_EQ("300x400",
984 test_api.GetRootWindow()->window()->bounds().size().ToString()); 985 test_api.GetRootWindow()->window()->bounds().size().ToString());
985 EXPECT_TRUE(display_manager->IsMirrored()); 986 EXPECT_TRUE(display_manager->IsMirrored());
986 987
987 display_manager->SetMirrorMode(false); 988 display_manager->SetMirrorMode(false);
988 EXPECT_TRUE(display_observer.changed_and_reset()); 989 EXPECT_TRUE(display_observer.changed_and_reset());
989 EXPECT_EQ(NULL, test_api.GetRootWindow()); 990 EXPECT_EQ(NULL, test_api.GetRootWindow());
990 EXPECT_EQ(2U, display_manager->GetNumDisplays()); 991 EXPECT_EQ(2U, display_manager->GetNumDisplays());
991 EXPECT_FALSE(display_manager->IsMirrored()); 992 EXPECT_FALSE(display_manager->IsMirrored());
992 993
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 1086
1086 TEST_F(DisplayManagerTest, MAYBE_UpdateDisplayWithHostOrigin) { 1087 TEST_F(DisplayManagerTest, MAYBE_UpdateDisplayWithHostOrigin) {
1087 UpdateDisplay("100x200,300x400"); 1088 UpdateDisplay("100x200,300x400");
1088 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays()); 1089 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays());
1089 aura::Window::Windows root_windows = 1090 aura::Window::Windows root_windows =
1090 Shell::GetInstance()->GetAllRootWindows(); 1091 Shell::GetInstance()->GetAllRootWindows();
1091 ASSERT_EQ(2U, root_windows.size()); 1092 ASSERT_EQ(2U, root_windows.size());
1092 aura::WindowEventDispatcher* dispatcher0 = root_windows[0]->GetDispatcher(); 1093 aura::WindowEventDispatcher* dispatcher0 = root_windows[0]->GetDispatcher();
1093 aura::WindowEventDispatcher* dispatcher1 = root_windows[1]->GetDispatcher(); 1094 aura::WindowEventDispatcher* dispatcher1 = root_windows[1]->GetDispatcher();
1094 1095
1095 EXPECT_EQ("1,1", dispatcher0->GetHostOrigin().ToString()); 1096 EXPECT_EQ("1,1", dispatcher0->host()->GetBounds().origin().ToString());
1096 EXPECT_EQ("100x200", dispatcher0->GetHostSize().ToString()); 1097 EXPECT_EQ("100x200", dispatcher0->host()->GetBounds().size().ToString());
1097 // UpdateDisplay set the origin if it's not set. 1098 // UpdateDisplay set the origin if it's not set.
1098 EXPECT_NE("1,1", dispatcher1->GetHostOrigin().ToString()); 1099 EXPECT_NE("1,1", dispatcher1->host()->GetBounds().origin().ToString());
1099 EXPECT_EQ("300x400", dispatcher1->GetHostSize().ToString()); 1100 EXPECT_EQ("300x400", dispatcher1->host()->GetBounds().size().ToString());
1100 1101
1101 UpdateDisplay("100x200,200+300-300x400"); 1102 UpdateDisplay("100x200,200+300-300x400");
1102 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays()); 1103 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays());
1103 EXPECT_EQ("0,0", dispatcher0->GetHostOrigin().ToString()); 1104 EXPECT_EQ("0,0", dispatcher0->host()->GetBounds().origin().ToString());
1104 EXPECT_EQ("100x200", dispatcher0->GetHostSize().ToString()); 1105 EXPECT_EQ("100x200", dispatcher0->host()->GetBounds().size().ToString());
1105 EXPECT_EQ("200,300", dispatcher1->GetHostOrigin().ToString()); 1106 EXPECT_EQ("200,300", dispatcher1->host()->GetBounds().origin().ToString());
1106 EXPECT_EQ("300x400", dispatcher1->GetHostSize().ToString()); 1107 EXPECT_EQ("300x400", dispatcher1->host()->GetBounds().size().ToString());
1107 1108
1108 UpdateDisplay("400+500-200x300,300x400"); 1109 UpdateDisplay("400+500-200x300,300x400");
1109 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays()); 1110 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays());
1110 EXPECT_EQ("400,500", dispatcher0->GetHostOrigin().ToString()); 1111 EXPECT_EQ("400,500", dispatcher0->host()->GetBounds().origin().ToString());
1111 EXPECT_EQ("200x300", dispatcher0->GetHostSize().ToString()); 1112 EXPECT_EQ("200x300", dispatcher0->host()->GetBounds().size().ToString());
1112 EXPECT_EQ("0,0", dispatcher1->GetHostOrigin().ToString()); 1113 EXPECT_EQ("0,0", dispatcher1->host()->GetBounds().origin().ToString());
1113 EXPECT_EQ("300x400", dispatcher1->GetHostSize().ToString()); 1114 EXPECT_EQ("300x400", dispatcher1->host()->GetBounds().size().ToString());
1114 1115
1115 UpdateDisplay("100+200-100x200,300+500-200x300"); 1116 UpdateDisplay("100+200-100x200,300+500-200x300");
1116 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays()); 1117 ASSERT_EQ(2, Shell::GetScreen()->GetNumDisplays());
1117 EXPECT_EQ("100,200", dispatcher0->GetHostOrigin().ToString()); 1118 EXPECT_EQ("100,200", dispatcher0->host()->GetBounds().origin().ToString());
1118 EXPECT_EQ("100x200", dispatcher0->GetHostSize().ToString()); 1119 EXPECT_EQ("100x200", dispatcher0->host()->GetBounds().size().ToString());
1119 EXPECT_EQ("300,500", dispatcher1->GetHostOrigin().ToString()); 1120 EXPECT_EQ("300,500", dispatcher1->host()->GetBounds().origin().ToString());
1120 EXPECT_EQ("200x300", dispatcher1->GetHostSize().ToString()); 1121 EXPECT_EQ("200x300", dispatcher1->host()->GetBounds().size().ToString());
1121 } 1122 }
1122 1123
1123 } // namespace internal 1124 } // namespace internal
1124 } // namespace ash 1125 } // namespace ash
OLDNEW
« no previous file with comments | « ash/display/display_controller_unittest.cc ('k') | ash/display/mirror_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698